From f4aadcbbfce389e88d0fd24335e243626beb6dc3 Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Tue, 17 Jun 2014 16:35:23 +0800 Subject: [PATCH] Do not disable detached devtools. --- atom/browser/native_window.cc | 16 ---------------- atom/browser/native_window.h | 3 --- 2 files changed, 19 deletions(-) diff --git a/atom/browser/native_window.cc b/atom/browser/native_window.cc index 68bec9352b7e..97a4ae515f06 100644 --- a/atom/browser/native_window.cc +++ b/atom/browser/native_window.cc @@ -569,22 +569,6 @@ void NativeWindow::Observe(int type, } } -bool NativeWindow::DevToolsSetDockSide(const std::string& dock_side, - bool* succeed) { - if (dock_side == "undocked") { - *succeed = false; - return true; - } else { - return false; - } -} - -bool NativeWindow::DevToolsShow(std::string* dock_side) { - if (*dock_side == "undocked") - *dock_side = "bottom"; - return false; -} - void NativeWindow::DevToolsSaveToFile(const std::string& url, const std::string& content, bool save_as) { diff --git a/atom/browser/native_window.h b/atom/browser/native_window.h index 7fd79a55c20a..9562d863b85b 100644 --- a/atom/browser/native_window.h +++ b/atom/browser/native_window.h @@ -242,9 +242,6 @@ class NativeWindow : public brightray::DefaultWebContentsDelegate, const content::NotificationDetails& details) OVERRIDE; // Implementations of brightray::InspectableWebContentsDelegate. - virtual bool DevToolsSetDockSide(const std::string& dock_side, - bool* succeed) OVERRIDE; - virtual bool DevToolsShow(std::string* dock_side) OVERRIDE; virtual void DevToolsSaveToFile(const std::string& url, const std::string& content, bool save_as) OVERRIDE;