mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Throw errors reading/parsing manifest.json

Browse source
This commit is contained in:
Kevin Sawicki 2016-06-09 09:45:02 -07:00
parent d1ac5dd29b
commit f46edd5186
1 changed files with 14 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

18
lib/browser/chrome-extension.js
View file

@ -22,12 +22,22 @@ const generateExtensionIdFromName = function (name) {
// Create or get manifest object from |srcDirectory|. // Create or get manifest object from |srcDirectory|.
const getManifestFromPath = function (srcDirectory) { const getManifestFromPath = function (srcDirectory) {
let manifest let manifest
let manifestContent
try { try {
manifest = JSON.parse(fs.readFileSync(path.join(srcDirectory, 'manifest.json'))) manifestContent = fs.readFileSync(path.join(srcDirectory, 'manifest.json'))
} catch (err) { } catch (readError) {
console.warn(`Attempted to load extension from ${srcDirectory}, but parsing the manifest failed.`) console.warn(`Reading ${path.join(srcDirectory, 'manifest.json')} failed.`)
console.warn('Error encountered:', err) console.warn(readError.stack || readError)
throw readError
}
try {
manifest = JSON.parse(manifestContent)
} catch (parseError) {
console.warn(`Parsing ${path.join(srcDirectory, 'manifest.json')} failed.`)
console.warn(parseError.stack || parseError)
throw parseError
} }
if (!manifestNameMap[manifest.name]) { if (!manifestNameMap[manifest.name]) {