mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: warn when using the deprecated new-window event (#34528)

Browse source
This commit is contained in:
Milan Burda 2022-06-16 03:17:42 +02:00 • committed by GitHub
parent bad8d5e08a
commit f418a49857
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
lib/browser/guest-window-manager.ts
View file

@ -5,7 +5,7 @@
* out-of-process (cross-origin) are created here. "Embedder" roughly means * out-of-process (cross-origin) are created here. "Embedder" roughly means
* "parent." * "parent."
*/ */
import { BrowserWindow } from 'electron/main'; import { BrowserWindow, deprecate } from 'electron/main';
import type { BrowserWindowConstructorOptions, Referrer, WebContents, LoadURLOptions } from 'electron/main'; import type { BrowserWindowConstructorOptions, Referrer, WebContents, LoadURLOptions } from 'electron/main';
import { parseFeatures } from '@electron/internal/browser/parse-features-string'; import { parseFeatures } from '@electron/internal/browser/parse-features-string';
@ -155,6 +155,10 @@ function emitDeprecatedNewWindowEvent ({ event, embedder, guest, windowOpenArgs,
...parseContentTypeFormat(postData) ...parseContentTypeFormat(postData)
} : null; } : null;
if (embedder.listenerCount('new-window') > 0) {
deprecate.log('The new-window event is deprecated and will be removed. Please use contents.setWindowOpenHandler() instead.');
}
embedder.emit( embedder.emit(
'new-window', 'new-window',
event, event,