mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Converted callback can only be called for once

Browse source
This commit is contained in:
Cheng Zhao 2015-10-28 20:44:46 +08:00
parent 4eac6b31b1
commit f40a3f72d7
3 changed files with 32 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

29
atom/common/native_mate_converters/callback.cc
View file

@ -4,23 +4,36 @@
#include "atom/common/native_mate_converters/callback.h"
#include "native_mate/wrappable.h"
namespace mate {
namespace internal {
namespace {
struct TranslaterHolder : public Wrappable {
struct TranslaterHolder {
Translater translater;
};
// Cached JavaScript version of |CallTranslater|.
v8::Persistent<v8::FunctionTemplate> g_call_translater;
void CallTranslater(TranslaterHolder* holder, mate::Arguments* args) {
void CallTranslater(v8::Local<v8::External> external,
v8::Local<v8::Object> state,
mate::Arguments* args) {
v8::Isolate* isolate = args->isolate();
// Check if the callback has already been called.
v8::Local<v8::String> called_symbol = mate::StringToSymbol(isolate, "called");
if (state->Has(called_symbol)) {
args->ThrowError("callback can only be called for once");
return;
} else {
state->Set(called_symbol, v8::Boolean::New(isolate, true));
}
TranslaterHolder* holder = static_cast<TranslaterHolder*>(external->Value());
holder->translater.Run(args);
delete holder;
}
// func.bind(func, arg1).
@ -28,12 +41,13 @@ void CallTranslater(TranslaterHolder* holder, mate::Arguments* args) {
v8::Local<v8::Value> BindFunctionWith(v8::Isolate* isolate,
v8::Local<v8::Context> context,
v8::Local<v8::Function> func,
v8::Local<v8::Value> arg1) {
v8::Local<v8::Value> arg1,
v8::Local<v8::Value> arg2) {
v8::MaybeLocal<v8::Value> bind = func->Get(mate::StringToV8(isolate, "bind"));
CHECK(!bind.IsEmpty());
v8::Local<v8::Function> bind_func =
v8::Local<v8::Function>::Cast(bind.ToLocalChecked());
v8::Local<v8::Value> converted[] = { func, arg1 };
v8::Local<v8::Value> converted[] = { func, arg1, arg2 };
return bind_func->Call(
context, func, arraysize(converted), converted).ToLocalChecked();
}
@ -55,7 +69,8 @@ v8::Local<v8::Value> CreateFunctionFromTranslater(
return BindFunctionWith(isolate,
isolate->GetCurrentContext(),
call_translater->GetFunction(),
holder->GetWrapper(isolate));
v8::External::New(isolate, holder),
v8::Object::New(isolate));
}
} // namespace internal