mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

factor out parse-features-string.js

Browse source
This commit is contained in:
Paul Frazee 2016-10-24 20:21:42 -05:00
parent e7962c7ba2
commit f35536bdc5
3 changed files with 35 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

19
lib/browser/guest-view-manager.js
View file

@ -2,6 +2,7 @@
const ipcMain = require('electron').ipcMain
const webContents = require('electron').webContents
const parseFeaturesString = require('../common/parse-features-string')
// Doesn't exist in early initialization.
let webViewManager = null
@ -187,27 +188,13 @@ const attachGuest = function (embedder, elementInstanceId, guestInstanceId, para
// parse the 'webpreferences' attribute string, if set
// this uses the same parsing rules as window.open uses for its features
if (typeof params.webpreferences === 'string') {
// split the attribute's value by ','
let i, len
let webpreferencesTokens = params.webpreferences.split(/,\s*/)
for (i = 0, len = webpreferencesTokens.length; i < len; i++) {
// expected form is either a name by itself (true boolean flag)
// or a key/value, in the form of 'name=value'
// split the tokens by '='
let pref = webpreferencesTokens[i]
let prefTokens = pref.split(/\s*=/)
let name = prefTokens[0]
let value = prefTokens[1]
if (!name) continue
// interpret the value as a boolean, if possible
value = (value === 'yes' || value === '1') ? true : (value === 'no' || value === '0') ? false : value
parseFeaturesString(params.webpreferences, function (key, value) {
if (value === undefined) {
// no value was specified, default it to true
value = true
}
webPreferences[name] = value
}
})
}
if (params.preload) {