mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

test: ensure legacy callback functions work (#16436)

Browse source 
* test: test legacy callback functions

* add TODO removal comments

* fix callback spec
This commit is contained in:
Shelley Vohr 2019-01-17 14:17:16 -08:00 • committed by GitHub
parent 720197f9c8
commit f105c84349
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 114 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

32
spec/api-app-spec.js
View file

@ -836,7 +836,7 @@ describe('app module', () => {
})
})
describe('getFileIcon() API', () => {
describe('getFileIcon() API', (done) => {
const iconPath = path.join(__dirname, 'fixtures/assets/icon.ico')
const sizes = {
small: 16,
@ -858,6 +858,14 @@ describe('app module', () => {
expect(icon.isEmpty()).to.be.false()
})
// TODO(codebytere): remove when promisification is complete
it('fetches a non-empty icon (callback)', () => {
app.getFileIcon(iconPath, (icon) => {
expect(icon.isEmpty()).to.be.false()
done()
})
})
it('fetches normal icon size by default', async () => {
const icon = await app.getFileIcon(iconPath)
const size = icon.getSize()
@ -866,6 +874,17 @@ describe('app module', () => {
expect(size.width).to.equal(sizes.normal)
})
// TODO(codebytere): remove when promisification is complete
it('fetches normal icon size by default (callback)', () => {
app.getFileIcon(iconPath, (icon) => {
const size = icon.getSize()
expect(size.height).to.equal(sizes.normal)
expect(size.width).to.equal(sizes.normal)
done()
})
})
describe('size option', () => {
it('fetches a small icon', async () => {
const icon = await app.getFileIcon(iconPath, { size: 'small' })
@ -883,6 +902,17 @@ describe('app module', () => {
expect(size.width).to.equal(sizes.normal)
})
// TODO(codebytere): remove when promisification is complete
it('fetches a normal icon (callback)', () => {
app.getFileIcon(iconPath, { size: 'normal' }, (icon) => {
const size = icon.getSize()
expect(size.height).to.equal(sizes.normal)
expect(size.width).to.equal(sizes.normal)
done()
})
})
it('fetches a large icon', async () => {
// macOS does not support large icons
if (process.platform === 'darwin') return