mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

test: ensure legacy callback functions work (#16436)

Browse source 
* test: test legacy callback functions

* add TODO removal comments

* fix callback spec
This commit is contained in:
Shelley Vohr 2019-01-17 14:17:16 -08:00 • committed by GitHub
parent 720197f9c8
commit f105c84349
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 114 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/browser/api/app.js
View file

@ -33,7 +33,7 @@ Object.assign(app, {
}
})
app.getFileIcon = deprecate.promisify(app.getFileIcon, 2)
app.getFileIcon = deprecate.promisify(app.getFileIcon, 3)
const nativeAppMetrics = app.getAppMetrics
app.getAppMetrics = () => {

2
lib/browser/api/session.js
View file

@ -20,6 +20,6 @@ Object.setPrototypeOf(Session.prototype, EventEmitter.prototype)
Object.setPrototypeOf(Cookies.prototype, EventEmitter.prototype)
Session.prototype._init = function () {
this.protocol.isProtocolHandled = deprecate.promisify(this.protocol.isProtocolHandled, 1)
this.protocol.isProtocolHandled = deprecate.promisify(this.protocol.isProtocolHandled, 2)
app.emit('session-created', this)
}

2
lib/browser/api/web-contents.js
View file

@ -334,7 +334,7 @@ WebContents.prototype._init = function () {
// render-view-deleted event, so ignore the listeners warning.
this.setMaxListeners(0)
this.capturePage = deprecate.promisify(this.capturePage, 1)
this.capturePage = deprecate.promisify(this.capturePage, 2)
// Dispatch IPC messages to the ipc module.
this.on('ipc-message', function (event, [channel, ...args]) {