mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: clean up Session with CleanedUpAtExit (#24603)

Browse source
This commit is contained in:
Jeremy Rose 2020-07-20 12:13:33 -07:00 • committed by GitHub
parent e5cb22b7f9
commit f0953902db
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 17 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

18
shell/common/gin_helper/cleaned_up_at_exit.cc
View file

@ -4,29 +4,31 @@
#include "shell/common/gin_helper/cleaned_up_at_exit.h"
#include "base/containers/flat_set.h"
#include <algorithm>
#include <vector>
#include "base/no_destructor.h"
namespace gin_helper {
base::flat_set<CleanedUpAtExit*>& GetDoomed() {
static base::NoDestructor<base::flat_set<CleanedUpAtExit*>> doomed;
std::vector<CleanedUpAtExit*>& GetDoomed() {
static base::NoDestructor<std::vector<CleanedUpAtExit*>> doomed;
return *doomed;
}
CleanedUpAtExit::CleanedUpAtExit() {
GetDoomed().insert(this);
GetDoomed().emplace_back(this);
}
CleanedUpAtExit::~CleanedUpAtExit() {
GetDoomed().erase(this);
auto& doomed = GetDoomed();
doomed.erase(std::remove(doomed.begin(), doomed.end(), this), doomed.end());
}
// static
void CleanedUpAtExit::DoCleanup() {
auto& doomed = GetDoomed();
while (!doomed.empty()) {
auto iter = doomed.begin();
delete *iter;
// It removed itself from the list.
CleanedUpAtExit* next = doomed.back();
delete next;
}
}