mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: clean up Session with CleanedUpAtExit (#24603)

Browse source
This commit is contained in:
Jeremy Rose 2020-07-20 12:13:33 -07:00 • committed by GitHub
parent e5cb22b7f9
commit f0953902db
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 17 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

6
shell/browser/javascript_environment.cc
View file

@ -46,7 +46,6 @@ JavascriptEnvironment::~JavascriptEnvironment() {
{
v8::Locker locker(isolate_);
v8::HandleScope scope(isolate_);
gin_helper::CleanedUpAtExit::DoCleanup();
context_.Get(isolate_)->Exit();
}
isolate_->Exit();
@ -97,6 +96,11 @@ void JavascriptEnvironment::OnMessageLoopCreated() {
void JavascriptEnvironment::OnMessageLoopDestroying() {
DCHECK(microtasks_runner_);
{
v8::Locker locker(isolate_);
v8::HandleScope scope(isolate_);
gin_helper::CleanedUpAtExit::DoCleanup();
}
base::MessageLoopCurrent::Get()->RemoveTaskObserver(microtasks_runner_.get());
platform_->DrainTasks(isolate_);
platform_->UnregisterIsolate(isolate_);