refactor: clean up Session with CleanedUpAtExit (#24603)
This commit is contained in:
parent
e5cb22b7f9
commit
f0953902db
4 changed files with 17 additions and 11 deletions
|
@ -942,8 +942,6 @@ gin::Handle<Session> Session::CreateFrom(
|
|||
// The Sessions should never be garbage collected, since the common pattern is
|
||||
// to use partition strings, instead of using the Session object directly.
|
||||
handle->Pin(isolate);
|
||||
ElectronBrowserMainParts::Get()->RegisterDestructionCallback(
|
||||
base::BindOnce([](Session* session) { delete session; }, handle.get()));
|
||||
|
||||
App::Get()->EmitCustomEvent("session-created",
|
||||
handle.ToV8().As<v8::Object>());
|
||||
|
|
|
@ -15,6 +15,7 @@
|
|||
#include "gin/wrappable.h"
|
||||
#include "shell/browser/event_emitter_mixin.h"
|
||||
#include "shell/browser/net/resolve_proxy_helper.h"
|
||||
#include "shell/common/gin_helper/cleaned_up_at_exit.h"
|
||||
#include "shell/common/gin_helper/error_thrower.h"
|
||||
#include "shell/common/gin_helper/function_template_extensions.h"
|
||||
#include "shell/common/gin_helper/pinnable.h"
|
||||
|
@ -51,6 +52,7 @@ namespace api {
|
|||
class Session : public gin::Wrappable<Session>,
|
||||
public gin_helper::Pinnable<Session>,
|
||||
public gin_helper::EventEmitterMixin<Session>,
|
||||
public gin_helper::CleanedUpAtExit,
|
||||
#if BUILDFLAG(ENABLE_BUILTIN_SPELLCHECKER)
|
||||
public SpellcheckHunspellDictionary::Observer,
|
||||
#endif
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue