mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Fix path comparison in api-ipc-spec

Browse source 
One of the tests failed because in one of the paths the drive letter was
upper case `C` and in the other it was lower case `c`.
Paths in Windows are case insensitive, so this shouldn't fail. The fix
was to lower case the paths before comparison (only on Windows).
This commit is contained in:
Eran Tiktin 2015-08-22 19:50:54 +03:00
parent d7cf460918
commit f05ee4205d
1 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
spec/api-ipc-spec.coffee
View file

@ -5,6 +5,13 @@ remote = require 'remote'
BrowserWindow = remote.require 'browser-window'
comparePaths = (path1, path2) ->
if process.platform is 'win32'
# Paths in Windows are case insensitive.
path1 = path1.toLowerCase()
path2 = path2.toLowerCase()
assert.equal path1, path2
describe 'ipc module', ->
fixtures = path.join __dirname, 'fixtures'
@ -19,8 +26,8 @@ describe 'ipc module', ->
assert.equal a.id, 1127
it 'should search module from the user app', ->
assert.equal path.normalize(remote.process.mainModule.filename), path.resolve(__dirname, 'static', 'main.js')
assert.equal path.normalize(remote.process.mainModule.paths[0]), path.resolve(__dirname, 'static', 'node_modules')
comparePaths path.normalize(remote.process.mainModule.filename), path.resolve(__dirname, 'static', 'main.js')
comparePaths path.normalize(remote.process.mainModule.paths[0]), path.resolve(__dirname, 'static', 'node_modules')
describe 'remote.createFunctionWithReturnValue', ->
it 'should be called in browser synchronously', ->