From f02f9ba9fb96e0e7a42f98c973db4e39d3969447 Mon Sep 17 00:00:00 2001 From: Samuel Attard Date: Wed, 21 Nov 2018 08:23:50 +1100 Subject: [PATCH] chore: add spec for --inspect after a -- (#15237) --- spec/fixtures/module/noop.js | 1 + spec/node-spec.js | 18 ++++++++++++++++++ 2 files changed, 19 insertions(+) create mode 100644 spec/fixtures/module/noop.js diff --git a/spec/fixtures/module/noop.js b/spec/fixtures/module/noop.js new file mode 100644 index 00000000000..23d7e999157 --- /dev/null +++ b/spec/fixtures/module/noop.js @@ -0,0 +1 @@ +process.exit(0) diff --git a/spec/node-spec.js b/spec/node-spec.js index 7b2cbba3893..edff640e6d5 100644 --- a/spec/node-spec.js +++ b/spec/node-spec.js @@ -239,6 +239,24 @@ describe('node feature', () => { child.stdout.on('data', outDataHandler) }) + it('does not start the v8 inspector when --inspect is after a -- argument', (done) => { + child = ChildProcess.spawn(remote.process.execPath, [path.join(__dirname, 'fixtures', 'module', 'noop.js'), '--', '--inspect']) + + let output = '' + function dataListener (data) { + output += data + } + child.stderr.on('data', dataListener) + child.stdout.on('data', dataListener) + child.on('exit', () => { + if (output.trim().startsWith('Debugger listening on ws://')) { + done(new Error('Inspector was started when it should not have been')) + } else { + done() + } + }) + }) + it('supports js binding', (done) => { child = ChildProcess.spawn(process.execPath, ['--inspect', path.join(__dirname, 'fixtures', 'module', 'inspector-binding.js')], { env: {