chore: cleanup unusued variables + enable linting (#38898)

This commit is contained in:
Milan Burda 2023-06-26 11:51:54 +02:00 committed by GitHub
parent e900f6ecc3
commit ef6569b7d3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
36 changed files with 31 additions and 89 deletions

View file

@ -2,7 +2,6 @@ if (!process.env.CI) require('dotenv-safe').load();
const assert = require('node:assert');
const got = require('got');
const { Octokit } = require('@octokit/rest');
const BUILD_APPVEYOR_URL = 'https://ci.appveyor.com/api/builds';
const CIRCLECI_PIPELINE_URL = 'https://circleci.com/api/v2/project/gh/electron/electron/pipeline';

View file

@ -256,7 +256,7 @@ async function runRetryable (fn, maxRetries) {
try {
return await fn();
} catch (error) {
await new Promise((resolve, reject) => setTimeout(resolve, CHECK_INTERVAL));
await new Promise(resolve => setTimeout(resolve, CHECK_INTERVAL));
lastError = error;
}
}

View file

@ -173,7 +173,7 @@ async function verifyNewVersion () {
}
async function promptForVersion (version) {
return new Promise((resolve, reject) => {
return new Promise(resolve => {
const rl = readline.createInterface({
input: process.stdin,
output: process.stdout

View file

@ -2,7 +2,6 @@ const temp = require('temp');
const fs = require('node:fs');
const path = require('node:path');
const childProcess = require('node:child_process');
const got = require('got');
const semver = require('semver');
const { getCurrentBranch, ELECTRON_DIR } = require('../lib/utils');

View file

@ -5,9 +5,6 @@ const args = require('minimist')(process.argv.slice(2), {
string: ['tag', 'releaseID'],
default: { releaseID: '' }
});
const { execSync } = require('node:child_process');
const { GitProcess } = require('dugite');
const { getCurrentBranch, ELECTRON_DIR } = require('../lib/utils.js');
const { Octokit } = require('@octokit/rest');
const octokit = new Octokit({

View file

@ -15,7 +15,6 @@ const got = require('got');
const path = require('node:path');
const semver = require('semver');
const temp = require('temp').track();
const { URL } = require('node:url');
const { BlobServiceClient } = require('@azure/storage-blob');
const { Octokit } = require('@octokit/rest');
@ -299,7 +298,7 @@ async function uploadShasumFile (filePath, fileName, releaseId) {
}
function saveShaSumFile (checksums, fileName) {
return new Promise((resolve, reject) => {
return new Promise(resolve => {
temp.open(fileName, (err, info) => {
if (err) {
console.error(`${fail} Could not create ${fileName} file`);
@ -372,18 +371,6 @@ async function makeRelease (releaseToValidate) {
}
}
async function makeTempDir () {
return new Promise((resolve, reject) => {
temp.mkdir('electron-publish', (err, dirPath) => {
if (err) {
reject(err);
} else {
resolve(dirPath);
}
});
});
}
const SHASUM_256_FILENAME = 'SHASUMS256.txt';
const SHASUM_1_FILENAME = 'SHASUMS.txt';

View file

@ -12,7 +12,7 @@ function parseCommandLine () {
string: ['bump', 'version'],
boolean: ['dryRun', 'help'],
alias: { version: ['v'] },
unknown: arg => { help = true; }
unknown: () => { help = true; }
});
if (help || opts.help || !opts.bump) {
console.log(`
@ -33,14 +33,6 @@ async function main () {
const currentVersion = getElectronVersion();
const version = await nextVersion(opts.bump, currentVersion);
const parsed = semver.parse(version);
const components = {
major: parsed.major,
minor: parsed.minor,
patch: parsed.patch,
pre: parsed.prerelease
};
// print would-be new version and exit early
if (opts.dryRun) {
console.log(`new version number would be: ${version}\n`);
@ -97,18 +89,6 @@ async function nextVersion (bumpType, version) {
return version;
}
function isMajorStable (bump, currentVersion) {
if (versionUtils.isBeta(currentVersion) && (bump === 'stable')) return true;
return false;
}
function isMajorNightly (version, currentVersion) {
const parsed = semver.parse(version);
const current = semver.parse(currentVersion);
if (versionUtils.isNightly(currentVersion) && (parsed.major > current.major)) return true;
return false;
}
if (require.main === module) {
main().catch((error) => {
console.error(error);

View file

@ -1,13 +1,8 @@
const path = require('node:path');
const fs = require('node:fs');
const semver = require('semver');
const { GitProcess } = require('dugite');
const { promisify } = require('node:util');
const { ELECTRON_DIR } = require('../lib/utils');
const readFile = promisify(fs.readFile);
const preType = {
NONE: 'none',
PARTIAL: 'partial',