mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: rename TopLevelWindow to BaseWindow (#24305)

Browse source
This commit is contained in:
Cheng Zhao 2020-06-29 16:06:20 +09:00 • committed by GitHub
parent 80e5007c47
commit ef3579eae3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
21 changed files with 433 additions and 451 deletions
Download patch file Download diff file Expand all files Collapse all files

8
shell/common/gin_converters/native_window_converter.h
View file

@ -6,7 +6,7 @@
#define SHELL_COMMON_GIN_CONVERTERS_NATIVE_WINDOW_CONVERTER_H_
#include "gin/converter.h"
#include "shell/browser/api/electron_api_top_level_window.h"
#include "shell/browser/api/electron_api_base_window.h"
namespace gin {
@ -21,9 +21,9 @@ struct Converter<electron::NativeWindow*> {
return true;
}
electron::api::TopLevelWindow* window;
if (!gin::Converter<electron::api::TopLevelWindow*>::FromV8(isolate, val,
&window))
electron::api::BaseWindow* window;
if (!gin::Converter<electron::api::BaseWindow*>::FromV8(isolate, val,
&window))
return false;
*out = window->window();
return true;

2
shell/common/node_bindings.cc
View file

@ -52,7 +52,7 @@
V(electron_browser_protocol) \
V(electron_browser_session) \
V(electron_browser_system_preferences) \
V(electron_browser_top_level_window) \
V(electron_browser_base_window) \
V(electron_browser_tray) \
V(electron_browser_view) \
V(electron_browser_web_contents) \