mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: flakey extension bg page test (#29744)

Browse source
This commit is contained in:
Samuel Maddock 2021-06-20 21:11:40 -04:00 • committed by GitHub
parent e54667e17e
commit ef2ce9dd67
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

9
spec-main/extensions-spec.ts
View file

@ -432,12 +432,11 @@ describe('chrome extensions', () => {
it('has session in background page', async () => { it('has session in background page', async () => {
const customSession = session.fromPartition(`persist:${require('uuid').v4()}`); const customSession = session.fromPartition(`persist:${require('uuid').v4()}`);
const promise = emittedOnce(app, 'web-contents-created'); const promise = emittedOnce(app, 'web-contents-created');
await customSession.loadExtension(path.join(fixtures, 'extensions', 'persistent-background-page')); const { id } = await customSession.loadExtension(path.join(fixtures, 'extensions', 'persistent-background-page'));
const w = new BrowserWindow({ show: false, webPreferences: { session: customSession } });
await w.loadURL('about:blank');
const [, bgPageContents] = await promise; const [, bgPageContents] = await promise;
expect(bgPageContents.getType()).to.equal('backgroundPage'); expect(bgPageContents.getType()).to.equal('backgroundPage');
expect(bgPageContents.getURL()).to.match(/^chrome-extension:\/\/.+\/_generated_background_page.html$/); await emittedOnce(bgPageContents, 'did-finish-load');
expect(bgPageContents.getURL()).to.equal(`chrome-extension://${id}/_generated_background_page.html`);
expect(bgPageContents.session).to.not.equal(undefined); expect(bgPageContents.session).to.not.equal(undefined);
}); });
@ -445,8 +444,6 @@ describe('chrome extensions', () => {
const customSession = session.fromPartition(`persist:${require('uuid').v4()}`); const customSession = session.fromPartition(`persist:${require('uuid').v4()}`);
const promise = emittedOnce(app, 'web-contents-created'); const promise = emittedOnce(app, 'web-contents-created');
await customSession.loadExtension(path.join(fixtures, 'extensions', 'persistent-background-page')); await customSession.loadExtension(path.join(fixtures, 'extensions', 'persistent-background-page'));
const w = new BrowserWindow({ show: false, webPreferences: { session: customSession } });
await w.loadURL('about:blank');
const [, bgPageContents] = await promise; const [, bgPageContents] = await promise;
expect(bgPageContents.getType()).to.equal('backgroundPage'); expect(bgPageContents.getType()).to.equal('backgroundPage');
bgPageContents.openDevTools(); bgPageContents.openDevTools();