mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Remove unneeded AddRef/Release calls handled by base::Bind

Browse source
This commit is contained in:
Kevin Sawicki 2017-02-24 07:56:29 -08:00
parent 6837ec8576
commit ef085a1f15
1 changed files with 0 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
atom/browser/web_dialog_helper.cc
View file

@ -36,8 +36,6 @@ class FileSelectHelper : public base::RefCounted<FileSelectHelper>,
auto web_contents = content::WebContents::FromRenderFrameHost( auto web_contents = content::WebContents::FromRenderFrameHost(
render_frame_host); render_frame_host);
content::WebContentsObserver::Observe(web_contents); content::WebContentsObserver::Observe(web_contents);
// Add ref that will be released when the dialog is completed
AddRef();
} }
void ShowOpenDialog(const file_dialog::DialogSettings& settings) { void ShowOpenDialog(const file_dialog::DialogSettings& settings) {
@ -90,7 +88,6 @@ class FileSelectHelper : public base::RefCounted<FileSelectHelper>,
const std::vector<content::FileChooserFileInfo>& file_info) { const std::vector<content::FileChooserFileInfo>& file_info) {
if (render_frame_host_) if (render_frame_host_)
render_frame_host_->FilesSelectedInChooser(file_info, mode_); render_frame_host_->FilesSelectedInChooser(file_info, mode_);
Release();
} }
// content::WebContentsObserver: // content::WebContentsObserver: