mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Don't load remote properties until they are accessed

Browse source
This commit is contained in:
Kevin Sawicki 2016-09-14 13:21:44 -07:00
parent f792c720f4
commit eef42770c6
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
lib/renderer/api/remote.js
View file

@ -167,6 +167,11 @@ const proxyFunctionProperties = function (remoteMemberFunction, metaId, name) {
} }
return new Proxy(remoteMemberFunction, { return new Proxy(remoteMemberFunction, {
set: (target, property, value, receiver) => {
if (property !== 'ref') loadRemoteProperties()
target[property] = value
return true
},
get: (target, property, receiver) => { get: (target, property, receiver) => {
if (!target.hasOwnProperty(property)) loadRemoteProperties() if (!target.hasOwnProperty(property)) loadRemoteProperties()
return target[property] return target[property]

2
spec/api-ipc-spec.js
View file

@ -72,7 +72,7 @@ describe('ipc module', function () {
a = remote.require(path.join(fixtures, 'module', 'function-with-missing-properties.js')).setup() a = remote.require(path.join(fixtures, 'module', 'function-with-missing-properties.js')).setup()
assert.equal(a.bar(), true) assert.equal(a.bar(), true)
assert.equal(typeof a.bar.baz, 'function') assert.equal(a.bar.baz, undefined)
}) })
it('should work with static class members', function () { it('should work with static class members', function () {