mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

test: use async helpers to simplify tests (#37314)

Browse source 
test: use async helpers to simplify the tests

Co-authored-by: Milan Burda <miburda@microsoft.com>
This commit is contained in:
Milan Burda 2023-02-17 19:32:39 +01:00 • committed by GitHub
parent 0de1012280
commit ee87438d28
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 22 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

18
spec/webview-spec.ts
View file

@ -1774,6 +1774,14 @@ describe('<webview> tag', function () {
describe('<webview>.goForward()', () => {
useRemoteContext({ webPreferences: { webviewTag: true } });
itremote('should work after a replaced history entry', async (fixtures: string) => {
function waitForEvent (target: EventTarget, event: string) {
return new Promise<any>(resolve => target.addEventListener(event, resolve, { once: true }));
}
function waitForEvents (target: EventTarget, ...events: string[]) {
return Promise.all(events.map(event => waitForEvent(webview, event)));
}
const webview = new WebView();
webview.setAttribute('nodeintegration', 'on');
@ -1782,10 +1790,7 @@ describe('<webview> tag', function () {
document.body.appendChild(webview);
{
const [e] = await Promise.all([
new Promise<any>(resolve => webview.addEventListener('ipc-message', resolve, { once: true })),
new Promise<void>(resolve => webview.addEventListener('did-stop-loading', resolve, { once: true }))
]);
const [e] = await waitForEvents(webview, 'ipc-message', 'did-stop-loading');
expect(e.channel).to.equal('history');
expect(e.args[0]).to.equal(1);
expect(webview.canGoBack()).to.be.false();
@ -1802,10 +1807,7 @@ describe('<webview> tag', function () {
webview.goBack();
{
const [e] = await Promise.all([
new Promise<any>(resolve => webview.addEventListener('ipc-message', resolve, { once: true })),
new Promise<void>(resolve => webview.addEventListener('did-stop-loading', resolve, { once: true }))
]);
const [e] = await waitForEvents(webview, 'ipc-message', 'did-stop-loading');
expect(e.channel).to.equal('history');
expect(e.args[0]).to.equal(2);
expect(webview.canGoBack()).to.be.false();