From edd80d88a9fb8557352037791716ea8e6a48e487 Mon Sep 17 00:00:00 2001 From: Michael Vasseur Date: Wed, 5 Oct 2016 13:45:15 +0200 Subject: [PATCH] Update BrowserWindow's test to check additional features upon window.open() call --- spec/api-browser-window-spec.js | 3 ++- spec/fixtures/pages/window-open.html | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/spec/api-browser-window-spec.js b/spec/api-browser-window-spec.js index 6a839d91aa03..61c939ef24e4 100644 --- a/spec/api-browser-window-spec.js +++ b/spec/api-browser-window-spec.js @@ -818,10 +818,11 @@ describe('browser-window module', function () { } it('emits when window.open is called', function (done) { - w.webContents.once('new-window', function (e, url, frameName) { + w.webContents.once('new-window', function (e, url, frameName, disposition, options, additionalFeatures) { e.preventDefault() assert.equal(url, 'http://host/') assert.equal(frameName, 'host') + assert.equal(additionalFeatures[0], 'this-is-not-a-standard-feature') done() }) w.loadURL('file://' + fixtures + '/pages/window-open.html') diff --git a/spec/fixtures/pages/window-open.html b/spec/fixtures/pages/window-open.html index 94a7202db7c4..b7af009cd2b7 100644 --- a/spec/fixtures/pages/window-open.html +++ b/spec/fixtures/pages/window-open.html @@ -1,7 +1,7 @@