mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: lint spec-main (#20835)

Browse source
This commit is contained in:
Jeremy Apthorp 2019-11-01 13:37:02 -07:00 • committed by GitHub
parent 1fed1ed577
commit ecd9e1f26e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
51 changed files with 589 additions and 533 deletions
Download patch file Download diff file Expand all files Collapse all files

54
spec-main/api-net-spec.ts
View file

@ -34,13 +34,12 @@ function randomString (length: number) {
return buffer.toString()
}
function respondOnce(fn: http.RequestListener): Promise<string> {
function respondOnce (fn: http.RequestListener): Promise<string> {
return new Promise((resolve) => {
const server = http.createServer((request, response) => {
fn(request, response)
// don't close if a redirect was returned
if (response.statusCode < 300 || response.statusCode >= 399)
server.close()
if (response.statusCode < 300 || response.statusCode >= 399) { server.close() }
})
server.listen(0, '127.0.0.1', () => {
resolve(`http://127.0.0.1:${(server.address() as AddressInfo).port}`)
@ -61,7 +60,7 @@ respondOnce.toRoutes = (routes: Record<string, http.RequestListener>) => {
}
respondOnce.toURL = (url: string, fn: http.RequestListener) => {
return respondOnce.toRoutes({[url]: fn})
return respondOnce.toRoutes({ [url]: fn })
}
respondOnce.toSingleURL = (fn: http.RequestListener) => {
@ -459,7 +458,7 @@ describe('net module', () => {
let requestAbortEventEmitted = false
const urlRequest = net.request(serverUrl)
urlRequest.on('response', (response) => {
urlRequest.on('response', () => {
expect.fail('Unexpected response event')
})
urlRequest.on('finish', () => {
@ -484,14 +483,14 @@ describe('net module', () => {
it('it should be able to abort an HTTP request before request end', (done) => {
let requestReceivedByServer = false
let urlRequest: ClientRequest | null = null
respondOnce.toSingleURL((request, response) => {
respondOnce.toSingleURL(() => {
requestReceivedByServer = true
urlRequest!.abort()
}).then(serverUrl => {
let requestAbortEventEmitted = false
urlRequest = net.request(serverUrl)
urlRequest.on('response', (response) => {
urlRequest.on('response', () => {
expect.fail('Unexpected response event')
})
urlRequest.on('finish', () => {
@ -530,7 +529,7 @@ describe('net module', () => {
let requestFinishEventEmitted = false
urlRequest = net.request(serverUrl)
urlRequest.on('response', (response) => {
urlRequest.on('response', () => {
expect.fail('Unexpected response event')
})
urlRequest.on('finish', () => {
@ -571,8 +570,7 @@ describe('net module', () => {
requestResponseEventEmitted = true
const statusCode = response.statusCode
expect(statusCode).to.equal(200)
response.on('data', (chunk) => {
})
response.on('data', () => {})
response.on('end', () => {
expect.fail('Unexpected end event')
})
@ -608,7 +606,7 @@ describe('net module', () => {
it('abort event should be emitted at most once', (done) => {
let requestReceivedByServer = false
let urlRequest: ClientRequest | null = null
respondOnce.toSingleURL((request, response) => {
respondOnce.toSingleURL(() => {
requestReceivedByServer = true
urlRequest!.abort()
urlRequest!.abort()
@ -721,7 +719,7 @@ describe('net module', () => {
requestIsRedirected = true
response.end()
}).then(serverUrl => {
session.defaultSession.webRequest.onBeforeRequest((details, callback) => {
session.defaultSession.webRequest.onBeforeRequest(() => {
expect.fail('Request should not be intercepted by the default session')
})
@ -748,8 +746,7 @@ describe('net module', () => {
})
urlRequest.on('response', (response) => {
expect(response.statusCode).to.equal(200)
response.on('data', (chunk) => {
})
response.on('data', () => {})
response.on('end', () => {
expect(requestIsRedirected).to.be.true('The server should receive a request to the forward URL')
expect(requestIsIntercepted).to.be.true('The request should be intercepted by the webRequest module')
@ -769,7 +766,7 @@ describe('net module', () => {
requestIsRedirected = true
response.end()
}).then(serverUrl => {
session.defaultSession.webRequest.onBeforeRequest((details, callback) => {
session.defaultSession.webRequest.onBeforeRequest(() => {
expect.fail('Request should not be intercepted by the default session')
})
@ -796,8 +793,7 @@ describe('net module', () => {
})
urlRequest.on('response', (response) => {
expect(response.statusCode).to.equal(200)
response.on('data', (chunk) => {
})
response.on('data', () => {})
response.on('end', () => {
expect(requestIsRedirected).to.be.true('The server should receive a request to the forward URL')
expect(requestIsIntercepted).to.be.true('The request should be intercepted by the webRequest module')
@ -849,7 +845,7 @@ describe('net module', () => {
'/200': (request, response) => {
response.statusCode = 200
response.end()
},
}
}).then(serverUrl => {
const urlRequest = net.request({
url: `${serverUrl}${requestUrl}`
@ -877,7 +873,7 @@ describe('net module', () => {
'/200': (request, response) => {
response.statusCode = 200
response.end()
},
}
}).then(serverUrl => {
const urlRequest = net.request({
url: `${serverUrl}/redirectChain`
@ -925,7 +921,7 @@ describe('net module', () => {
'/200': (request, response) => {
response.statusCode = 200
response.end()
},
}
}).then(serverUrl => {
const urlRequest = net.request({
url: `${serverUrl}/redirectChain`,
@ -957,7 +953,7 @@ describe('net module', () => {
'/200': (request, response) => {
response.statusCode = 200
response.end()
},
}
}).then(serverUrl => {
const urlRequest = net.request({
url: `${serverUrl}/redirect`,
@ -991,7 +987,7 @@ describe('net module', () => {
url: 'https://foo',
session: 1 as any
})
}).to.throw("`session` should be an instance of the Session class")
}).to.throw('`session` should be an instance of the Session class')
})
it('should throw if given an invalid partition option', () => {
@ -1000,7 +996,7 @@ describe('net module', () => {
url: 'https://foo',
partition: 1 as any
})
}).to.throw("`partition` should be a string")
}).to.throw('`partition` should be a string')
})
it('should be able to create a request with options', (done) => {
@ -1059,7 +1055,7 @@ describe('net module', () => {
const netRequest = net.request(netServerUrl)
netRequest.on('response', (netResponse) => {
expect(netResponse.statusCode).to.equal(200)
netResponse.on('data', (chunk) => {})
netResponse.on('data', () => {})
netResponse.on('end', () => {
expect(netRequestReceived).to.be.true('net request received')
expect(netRequestEnded).to.be.true('net request ended')
@ -1073,7 +1069,7 @@ describe('net module', () => {
})
it('should emit error event on server socket close', (done) => {
respondOnce.toSingleURL((request, response) => {
respondOnce.toSingleURL((request) => {
request.socket.destroy()
}).then(serverUrl => {
let requestErrorEventEmitted = false
@ -1122,7 +1118,7 @@ describe('net module', () => {
const httpVersionMinor = response.httpVersionMinor
expect(httpVersionMinor).to.be.a('number').and.to.be.at.least(0)
response.on('data', chunk => {})
response.on('data', () => {})
response.on('end', () => { done() })
})
urlRequest.end()
@ -1156,7 +1152,7 @@ describe('net module', () => {
expect(headers).to.not.have.property(discardableHeader)
expect(headers[includedHeader]).to.equal(includedHeaderValue)
response.on('data', chunk => {})
response.on('data', () => {})
response.on('end', () => { done() })
})
urlRequest.end()
@ -1181,7 +1177,7 @@ describe('net module', () => {
expect(headers).to.have.property('referrer-policy')
expect(headers['referrer-policy']).to.equal('first-text, second-text')
response.on('data', chunk => {})
response.on('data', () => {})
response.on('end', () => { done() })
})
urlRequest.end()
@ -1215,7 +1211,7 @@ describe('net module', () => {
port: serverUrl.port
}
const nodeRequest = http.request(nodeOptions, res => {
res.on('data', (chunk) => {})
res.on('data', () => {})
res.on('end', () => {
done()
})