From ecb9e933942e6c891d1fe8a9855b7590d4e49cf4 Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Mon, 5 Jan 2015 15:29:26 -0800 Subject: [PATCH] File dialogs don't need icon --- atom/browser/api/atom_api_dialog.cc | 2 -- atom/browser/api/lib/dialog.coffee | 2 -- 2 files changed, 4 deletions(-) diff --git a/atom/browser/api/atom_api_dialog.cc b/atom/browser/api/atom_api_dialog.cc index e405cfb9ed23..5834b73e6b6d 100644 --- a/atom/browser/api/atom_api_dialog.cc +++ b/atom/browser/api/atom_api_dialog.cc @@ -69,7 +69,6 @@ void ShowMessageBox(int type, void ShowOpenDialog(const std::string& title, const base::FilePath& default_path, const file_dialog::Filters& filters, - const gfx::ImageSkia& icon, int properties, atom::NativeWindow* window, mate::Arguments* args) { @@ -91,7 +90,6 @@ void ShowOpenDialog(const std::string& title, void ShowSaveDialog(const std::string& title, const base::FilePath& default_path, const file_dialog::Filters& filters, - const gfx::ImageSkia& icon, atom::NativeWindow* window, mate::Arguments* args) { v8::Handle peek = args->PeekNext(); diff --git a/atom/browser/api/lib/dialog.coffee b/atom/browser/api/lib/dialog.coffee index ef458d6fdfbe..ddb5a20a7809 100644 --- a/atom/browser/api/lib/dialog.coffee +++ b/atom/browser/api/lib/dialog.coffee @@ -42,7 +42,6 @@ module.exports = options.title ?= '' options.defaultPath ?= '' options.filters ?= [] - options.icon ?= null wrappedCallback = if typeof callback is 'function' @@ -65,7 +64,6 @@ module.exports = options.title ?= '' options.defaultPath ?= '' options.filters ?= [] - options.icon ?= null wrappedCallback = if typeof callback is 'function'