mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix: requestFullscreen from WebContentsView (#41995)

Browse source 
fix: requestFullscreen from WebContentsView

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
This commit is contained in:
trop[bot] 2024-05-01 12:59:39 -04:00 committed by GitHub
parent 844265303c
commit ec4ffa99b6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 15 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
shell/browser/api/electron_api_web_contents_view.cc
View file

@ -89,6 +89,9 @@ void WebContentsView::OnViewAddedToWidget(views::View* observed_view) {
widget->GetNativeWindowProperty(electron::kElectronNativeWindowKey)); widget->GetNativeWindowProperty(electron::kElectronNativeWindowKey));
if (!native_window) if (!native_window)
return; return;
// We don't need to call SetOwnerWindow(nullptr) in OnViewRemovedFromWidget
// because that's handled in the WebContents dtor called prior.
api_web_contents_->SetOwnerWindow(native_window);
native_window->AddDraggableRegionProvider(this); native_window->AddDraggableRegionProvider(this);
} }

12
spec/api-web-contents-view-spec.ts
View file

@ -60,6 +60,18 @@ describe('WebContentsView', () => {
}); });
}); });
it('can be fullscreened', async () => {
const w = new BaseWindow();
const v = new WebContentsView();
w.setContentView(v);
await v.webContents.loadURL('data:text/html,<div id="div">This is a simple div.</div>');
const enterFullScreen = once(w, 'enter-full-screen');
await v.webContents.executeJavaScript('document.getElementById("div").requestFullscreen()', true);
await enterFullScreen;
expect(w.isFullScreen()).to.be.true('isFullScreen');
});
describe('visibilityState', () => { describe('visibilityState', () => {
it('is initially hidden', async () => { it('is initially hidden', async () => {
const v = new WebContentsView(); const v = new WebContentsView();