mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Use node::MakeCallback to emit events in C++

Browse source 
Fix #2165
This commit is contained in:
Cheng Zhao 2015-07-23 13:46:34 +08:00
parent 5a980497e8
commit eb92e9cdd8
1 changed files with 4 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

19
atom/common/event_emitter_caller.cc
View file

@ -4,6 +4,8 @@
#include "atom/common/event_emitter_caller.h"
#include "atom/common/node_includes.h"
namespace mate {
namespace internal {
@ -11,21 +13,8 @@ namespace internal {
v8::Local<v8::Value> CallEmitWithArgs(v8::Isolate* isolate,
v8::Local<v8::Object> obj,
ValueVector* args) {
v8::Local<v8::String> emit_name = StringToSymbol(isolate, "emit");
v8::Local<v8::Value> emit = obj->Get(emit_name);
if (emit.IsEmpty() || !emit->IsFunction()) {
isolate->ThrowException(v8::Exception::TypeError(
StringToV8(isolate, "\"emit\" is not a function")));
return v8::Undefined(isolate);
}
v8::MaybeLocal<v8::Value> result = emit.As<v8::Function>()->Call(
isolate->GetCurrentContext(), obj, args->size(), &args->front());
if (result.IsEmpty()) {
return v8::Undefined(isolate);
}
return result.ToLocalChecked();
return node::MakeCallback(
isolate, obj, "emit", args->size(), &args->front());
}
} // namespace internal