mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: stop using isolate() in WebContents (#24602)

Browse source
This commit is contained in:
Jeremy Rose 2020-07-16 14:11:44 -07:00 • committed by GitHub
parent f649e604be
commit eb7c04c7c4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 58 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

7
shell/browser/api/electron_api_web_contents.h
View file

@ -232,7 +232,7 @@ class WebContents : public gin_helper::TrackableObject<WebContents>,
bool IsCurrentlyAudible();
void SetEmbedder(const WebContents* embedder);
void SetDevToolsWebContents(const WebContents* devtools);
v8::Local<v8::Value> GetNativeView() const;
v8::Local<v8::Value> GetNativeView(v8::Isolate* isolate) const;
void IncrementCapturerCount(gin_helper::Arguments* args);
void DecrementCapturerCount(gin_helper::Arguments* args);
bool IsBeingCaptured();
@ -359,7 +359,7 @@ class WebContents : public gin_helper::TrackableObject<WebContents>,
v8::Local<v8::Value> GetLastWebPreferences(v8::Isolate* isolate) const;
// Returns the owner window.
v8::Local<v8::Value> GetOwnerBrowserWindow() const;
v8::Local<v8::Value> GetOwnerBrowserWindow(v8::Isolate* isolate) const;
// Grants the child process the capability to access URLs with the origin of
// the specified URL.
@ -368,7 +368,8 @@ class WebContents : public gin_helper::TrackableObject<WebContents>,
// Notifies the web page that there is user interaction.
void NotifyUserActivation();
v8::Local<v8::Promise> TakeHeapSnapshot(const base::FilePath& file_path);
v8::Local<v8::Promise> TakeHeapSnapshot(v8::Isolate* isolate,
const base::FilePath& file_path);
// Properties.
int32_t ID() const;