Rename FakeWindow to BrowserWindowProxy

This commit is contained in:
Cheng Zhao 2015-03-04 08:46:45 -08:00
parent 99f6bf045f
commit eb31df2940
2 changed files with 4 additions and 4 deletions

View file

@ -3,7 +3,7 @@ ipc = require 'ipc'
remote = require 'remote'
# Window object returned by "window.open".
class FakeWindow
class BrowserWindowProxy
constructor: (@guestId) ->
ipc.on 'ATOM_SHELL_GUEST_WINDOW_MANAGER_WINDOW_CLOSED', (guestId) =>
if guestId is @guestId
@ -53,7 +53,7 @@ window.open = (url, frameName='', features='') ->
guestId = ipc.sendSync 'ATOM_SHELL_GUEST_WINDOW_MANAGER_WINDOW_OPEN', url, frameName, options
if guestId
new FakeWindow(guestId)
new BrowserWindowProxy(guestId)
else
console.error 'It is not allowed to open new window from this WebContents'
null

View file

@ -32,9 +32,9 @@ describe 'chromium feature', ->
assert.notEqual navigator.language, ''
describe 'window.open', ->
it 'returns a FakeWindow object', ->
it 'returns a BrowserWindowProxy object', ->
b = window.open 'about:blank', 'test', 'show=no'
assert.equal b.constructor.name, 'FakeWindow'
assert.equal b.constructor.name, 'BrowserWindowProxy'
b.close()
describe 'creating a Uint8Array under browser side', ->