mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Rename FakeWindow to BrowserWindowProxy

Browse source
This commit is contained in:
Cheng Zhao 2015-03-04 08:46:45 -08:00
parent 99f6bf045f
commit eb31df2940
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
atom/renderer/lib/override.coffee
View file

@ -3,7 +3,7 @@ ipc = require 'ipc'
remote = require 'remote' remote = require 'remote'
# Window object returned by "window.open". # Window object returned by "window.open".
class FakeWindow class BrowserWindowProxy
constructor: (@guestId) -> constructor: (@guestId) ->
ipc.on 'ATOM_SHELL_GUEST_WINDOW_MANAGER_WINDOW_CLOSED', (guestId) => ipc.on 'ATOM_SHELL_GUEST_WINDOW_MANAGER_WINDOW_CLOSED', (guestId) =>
if guestId is @guestId if guestId is @guestId
@ -53,7 +53,7 @@ window.open = (url, frameName='', features='') ->
guestId = ipc.sendSync 'ATOM_SHELL_GUEST_WINDOW_MANAGER_WINDOW_OPEN', url, frameName, options guestId = ipc.sendSync 'ATOM_SHELL_GUEST_WINDOW_MANAGER_WINDOW_OPEN', url, frameName, options
if guestId if guestId
new FakeWindow(guestId) new BrowserWindowProxy(guestId)
else else
console.error 'It is not allowed to open new window from this WebContents' console.error 'It is not allowed to open new window from this WebContents'
null null

4
spec/chromium-spec.coffee
View file

@ -32,9 +32,9 @@ describe 'chromium feature', ->
assert.notEqual navigator.language, '' assert.notEqual navigator.language, ''
describe 'window.open', -> describe 'window.open', ->
it 'returns a FakeWindow object', -> it 'returns a BrowserWindowProxy object', ->
b = window.open 'about:blank', 'test', 'show=no' b = window.open 'about:blank', 'test', 'show=no'
assert.equal b.constructor.name, 'FakeWindow' assert.equal b.constructor.name, 'BrowserWindowProxy'
b.close() b.close()
describe 'creating a Uint8Array under browser side', -> describe 'creating a Uint8Array under browser side', ->