mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

refactor: migrates util::Promise to gin (#20871)

Browse source 
* refactor: use gin in Promise

* refactor: separate Promise impl that returns nothing

* refactor: use Promise<void> for promise that returns nothing

* fix: methods should be able to run on both browser and renderer process

* fix: should not pass base::StringPiece across threads

* refactor: no more need to use different ResolvePromise for empty Promise

* refactor: move Promise to gin_helper
This commit is contained in:
Cheng Zhao 2019-11-01 15:10:32 +09:00 • committed by GitHub
parent bff113760a
commit eaf2c61bef
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
48 changed files with 483 additions and 479 deletions
Download patch file Download diff file Expand all files Collapse all files

4
shell/browser/browser.h
View file

@ -16,7 +16,7 @@
#include "base/values.h"
#include "shell/browser/browser_observer.h"
#include "shell/browser/window_list_observer.h"
#include "shell/common/promise_util.h"
#include "shell/common/gin_helper/promise.h"
#if defined(OS_WIN)
#include <windows.h>
@ -304,7 +304,7 @@ class Browser : public WindowListObserver {
int badge_count_ = 0;
std::unique_ptr<util::Promise<void*>> ready_promise_;
std::unique_ptr<gin_helper::Promise<void>> ready_promise_;
#if defined(OS_LINUX) || defined(OS_WIN)
base::Value about_panel_options_;