From e5a57b02d806b76b1006da70f584e7beca5e343f Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Thu, 7 Aug 2014 10:48:02 +0800 Subject: [PATCH 1/2] Focus on devtools when it is opened on Mac. --- brightray/browser/mac/bry_inspectable_web_contents_view.mm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/brightray/browser/mac/bry_inspectable_web_contents_view.mm b/brightray/browser/mac/bry_inspectable_web_contents_view.mm index 084389dd92c0..a0e446338104 100644 --- a/brightray/browser/mac/bry_inspectable_web_contents_view.mm +++ b/brightray/browser/mac/bry_inspectable_web_contents_view.mm @@ -55,6 +55,9 @@ using namespace brightray; // sizes for them until the setContentsResizingStrategy message. [self addSubview:devToolsView positioned:NSWindowBelow relativeTo:nil]; [self update]; + + // Focus on web view. + devToolsWebContents->RestoreFocus(); } else { gfx::ScopedNSDisableScreenUpdates disabler; devToolsWebContents->RemoveOverlayView(); From f455798c055fcbbec8e287589fd4f4354f302575 Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Thu, 7 Aug 2014 10:50:50 +0800 Subject: [PATCH 2/2] Fix cpplint warnings. --- brightray/browser/devtools_delegate.cc | 1 - brightray/browser/devtools_delegate.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/brightray/browser/devtools_delegate.cc b/brightray/browser/devtools_delegate.cc index 682f06a2f40a..ded349dce67d 100644 --- a/brightray/browser/devtools_delegate.cc +++ b/brightray/browser/devtools_delegate.cc @@ -139,7 +139,6 @@ DevToolsDelegate::DevToolsDelegate( } DevToolsDelegate::~DevToolsDelegate() { - LOG(ERROR) << "delete!"; } void DevToolsDelegate::Stop() { diff --git a/brightray/browser/devtools_delegate.h b/brightray/browser/devtools_delegate.h index 5c8580a625ca..b75aeff04611 100644 --- a/brightray/browser/devtools_delegate.h +++ b/brightray/browser/devtools_delegate.h @@ -49,6 +49,6 @@ class DevToolsDelegate : public content::DevToolsHttpHandlerDelegate { DISALLOW_COPY_AND_ASSIGN(DevToolsDelegate); }; -} // namespace brightray +} // namespace brightray #endif // BRIGHTRAY_DEVTOOLS_DELEGATE_H_