mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: clang-tidy performance-inefficient-vector-operation warnings (32-x-y backport) (#44848)

Browse source 
fix: clang-tidy `performance-inefficient-vector-operation` warnings (#44743)

* fix: performance-inefficient-vector-operation warning in Clipboard::WriteFilesForTesting()

* fix: performance-inefficient-vector-operation warning in GetUploadedReports()
This commit is contained in:
Charles Kerr 2024-11-26 19:13:57 -06:00 • committed by GitHub
parent 4a3b3a6aee
commit e9da87822f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 14 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

24
shell/browser/api/electron_api_crash_reporter.cc
View file

@ -10,8 +10,7 @@
#include <utility> #include <utility>
#include <vector> #include <vector>
#include "base/command_line.h" #include "base/containers/to_vector.h"
#include "base/functional/bind.h"
#include "base/no_destructor.h" #include "base/no_destructor.h"
#include "base/path_service.h" #include "base/path_service.h"
#include "base/strings/utf_string_conversions.h" #include "base/strings/utf_string_conversions.h"
@ -223,18 +222,17 @@ v8::Local<v8::Value> GetUploadedReports(v8::Isolate* isolate) {
list->LoadSync(); list->LoadSync();
} }
auto to_obj = [isolate](const UploadList::UploadInfo* upload) {
return gin::DataObjectBuilder{isolate}
.Set("date", upload->upload_time)
.Set("id", upload->upload_id)
.Build();
};
constexpr size_t kMaxUploadReportsToList = std::numeric_limits<size_t>::max(); constexpr size_t kMaxUploadReportsToList = std::numeric_limits<size_t>::max();
const std::vector<const UploadList::UploadInfo*> uploads = return gin::ConvertToV8(
list->GetUploads(kMaxUploadReportsToList); isolate,
std::vector<v8::Local<v8::Object>> result; base::ToVector(list->GetUploads(kMaxUploadReportsToList), to_obj));
for (auto* const upload : uploads) {
result.push_back(gin::DataObjectBuilder(isolate)
.Set("date", upload->upload_time)
.Set("id", upload->upload_id)
.Build());
}
v8::Local<v8::Value> v8_result = gin::ConvertToV8(isolate, result);
return v8_result;
} }
#endif #endif

8
shell/common/api/electron_api_clipboard.cc
View file

@ -7,6 +7,7 @@
#include <map> #include <map>
#include "base/containers/contains.h" #include "base/containers/contains.h"
#include "base/containers/to_vector.h"
#include "base/run_loop.h" #include "base/run_loop.h"
#include "base/strings/utf_string_conversions.h" #include "base/strings/utf_string_conversions.h"
#include "shell/browser/browser.h" #include "shell/browser/browser.h"
@ -281,11 +282,8 @@ void Clipboard::Clear(gin_helper::Arguments* args) {
// This exists for testing purposes ONLY. // This exists for testing purposes ONLY.
void Clipboard::WriteFilesForTesting(const std::vector<base::FilePath>& files) { void Clipboard::WriteFilesForTesting(const std::vector<base::FilePath>& files) {
std::vector<ui::FileInfo> file_infos; auto to_info = [](const auto& p) { return ui::FileInfo{p, p.BaseName()}; };
for (const auto& file : files) { auto file_infos = base::ToVector(files, to_info);
file_infos.emplace_back(ui::FileInfo(ui::FileInfo(file, file.BaseName())));
}
ui::ScopedClipboardWriter writer(ui::ClipboardBuffer::kCopyPaste); ui::ScopedClipboardWriter writer(ui::ClipboardBuffer::kCopyPaste);
writer.WriteFilenames(ui::FileInfosToURIList(file_infos)); writer.WriteFilenames(ui::FileInfosToURIList(file_infos));
} }