mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: clang-tidy performance-inefficient-vector-operation warnings (32-x-y backport) (#44848)

Browse source 
fix: clang-tidy `performance-inefficient-vector-operation` warnings (#44743)

* fix: performance-inefficient-vector-operation warning in Clipboard::WriteFilesForTesting()

* fix: performance-inefficient-vector-operation warning in GetUploadedReports()
This commit is contained in:
Charles Kerr 2024-11-26 19:13:57 -06:00 • committed by GitHub
parent 4a3b3a6aee
commit e9da87822f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 14 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

8
shell/common/api/electron_api_clipboard.cc
View file

@ -7,6 +7,7 @@
#include <map>
#include "base/containers/contains.h"
#include "base/containers/to_vector.h"
#include "base/run_loop.h"
#include "base/strings/utf_string_conversions.h"
#include "shell/browser/browser.h"
@ -281,11 +282,8 @@ void Clipboard::Clear(gin_helper::Arguments* args) {
// This exists for testing purposes ONLY.
void Clipboard::WriteFilesForTesting(const std::vector<base::FilePath>& files) {
std::vector<ui::FileInfo> file_infos;
for (const auto& file : files) {
file_infos.emplace_back(ui::FileInfo(ui::FileInfo(file, file.BaseName())));
}
auto to_info = [](const auto& p) { return ui::FileInfo{p, p.BaseName()}; };
auto file_infos = base::ToVector(files, to_info);
ui::ScopedClipboardWriter writer(ui::ClipboardBuffer::kCopyPaste);
writer.WriteFilenames(ui::FileInfosToURIList(file_infos));
}