build: add import/order eslint rule (#44106)

build: add import/order eslint rule (#44085)

* build: add import/order eslint rule

* chore: run lint:js --fix

script/release/bin/cleanup-release.ts

@@ -1,4 +1,5 @@
 import { parseArgs } from 'node:util';
+
 import { cleanReleaseArtifacts } from '../release-artifact-cleanup';
 
 const { values: { tag: _tag, releaseID } } = parseArgs({

script/release/bin/publish-to-npm.ts

@@ -1,13 +1,13 @@
 import { Octokit } from '@octokit/rest';
-import * as childProcess from 'node:child_process';
-import * as fs from 'node:fs';
-import * as path from 'node:path';
 import * as semver from 'semver';
 import * as temp from 'temp';
 
-import { getCurrentBranch, ELECTRON_DIR } from '../../lib/utils';
-import { getElectronVersion } from '../../lib/get-version';
+import * as childProcess from 'node:child_process';
+import * as fs from 'node:fs';
+import * as path from 'node:path';
 
+import { getElectronVersion } from '../../lib/get-version';
+import { getCurrentBranch, ELECTRON_DIR } from '../../lib/utils';
 import { getAssetContents } from '../get-asset';
 import { createGitHubTokenStrategy } from '../github-token';
 import { ELECTRON_ORG, ELECTRON_REPO, ElectronReleaseRepo, NIGHTLY_REPO } from '../types';

script/release/find-github-release.ts

@@ -1,4 +1,5 @@
 import { Octokit } from '@octokit/rest';
+
 import { createGitHubTokenStrategy } from './github-token';
 import { ELECTRON_ORG, ELECTRON_REPO, ElectronReleaseRepo, NIGHTLY_REPO } from './types';
 

script/release/get-asset.ts

@@ -1,5 +1,6 @@
 import { Octokit } from '@octokit/rest';
 import got from 'got';
+
 import { createGitHubTokenStrategy } from './github-token';
 import { ELECTRON_ORG, ElectronReleaseRepo } from './types';
 

script/release/get-url-hash.ts

@@ -1,4 +1,5 @@
 import got from 'got';
+
 import * as url from 'node:url';
 
 const HASHER_FUNCTION_HOST = 'electron-artifact-hasher.azurewebsites.net';

script/release/notes/index.ts

@@ -1,15 +1,15 @@
 #!/usr/bin/env node
 
+import { Octokit } from '@octokit/rest';
 import { GitProcess } from 'dugite';
-import { basename } from 'node:path';
 import { valid, compare, gte, lte } from 'semver';
 
-import { ELECTRON_DIR } from '../../lib/utils';
-import { get, render } from './notes';
-
-import { Octokit } from '@octokit/rest';
-import { createGitHubTokenStrategy } from '../github-token';
+import { basename } from 'node:path';
 import { parseArgs } from 'node:util';
+
+import { get, render } from './notes';
+import { ELECTRON_DIR } from '../../lib/utils';
+import { createGitHubTokenStrategy } from '../github-token';
 import { ELECTRON_ORG, ELECTRON_REPO } from '../types';
 
 const octokit = new Octokit({

script/release/notes/notes.ts

@@ -1,11 +1,11 @@
 #!/usr/bin/env node
 
-import { existsSync, readFileSync, writeFileSync, mkdirSync } from 'node:fs';
-import { resolve as _resolve } from 'node:path';
-
 import { Octokit } from '@octokit/rest';
 import { GitProcess } from 'dugite';
 
+import { existsSync, readFileSync, writeFileSync, mkdirSync } from 'node:fs';
+import { resolve as _resolve } from 'node:path';
+
 import { ELECTRON_DIR } from '../../lib/utils';
 import { createGitHubTokenStrategy } from '../github-token';
 import { ELECTRON_ORG, ELECTRON_REPO } from '../types';

script/release/prepare-release.ts

@@ -1,14 +1,15 @@
 import { Octokit } from '@octokit/rest';
 import * as chalk from 'chalk';
 import { GitProcess } from 'dugite';
+
 import { execSync } from 'node:child_process';
 import { join } from 'node:path';
 
-import { runReleaseCIJobs } from './run-release-ci-jobs';
-import releaseNotesGenerator from './notes';
-import { getCurrentBranch, ELECTRON_DIR } from '../lib/utils.js';
 import { createGitHubTokenStrategy } from './github-token';
+import releaseNotesGenerator from './notes';
+import { runReleaseCIJobs } from './run-release-ci-jobs';
 import { ELECTRON_ORG, ElectronReleaseRepo, VersionBumpType } from './types';
+import { getCurrentBranch, ELECTRON_DIR } from '../lib/utils.js';
 
 const pass = chalk.green('✓');
 const fail = chalk.red('✗');

script/release/release.ts

@@ -4,17 +4,18 @@ import { BlobServiceClient } from '@azure/storage-blob';
 import { Octokit } from '@octokit/rest';
 import * as chalk from 'chalk';
 import got from 'got';
-import { execSync, ExecSyncOptions } from 'node:child_process';
-import { statSync, createReadStream, writeFileSync, close } from 'node:fs';
-import { join } from 'node:path';
 import { gte } from 'semver';
 import { track as trackTemp } from 'temp';
 
-import { ELECTRON_DIR } from '../lib/utils';
-import { getElectronVersion } from '../lib/get-version';
+import { execSync, ExecSyncOptions } from 'node:child_process';
+import { statSync, createReadStream, writeFileSync, close } from 'node:fs';
+import { join } from 'node:path';
+
 import { getUrlHash } from './get-url-hash';
 import { createGitHubTokenStrategy } from './github-token';
 import { ELECTRON_ORG, ELECTRON_REPO, ElectronReleaseRepo, NIGHTLY_REPO } from './types';
+import { getElectronVersion } from '../lib/get-version';
+import { ELECTRON_DIR } from '../lib/utils';
 
 const temp = trackTemp();
 

script/release/run-release-ci-jobs.ts

@@ -1,5 +1,6 @@
 import { Octokit } from '@octokit/rest';
 import got, { OptionsOfTextResponseBody } from 'got';
+
 import * as assert from 'node:assert';
 
 import { createGitHubTokenStrategy } from './github-token';

script/release/uploaders/upload-to-github.ts

@@ -1,5 +1,7 @@
 import { Octokit } from '@octokit/rest';
+
 import * as fs from 'node:fs';
+
 import { createGitHubTokenStrategy } from '../github-token';
 import { ELECTRON_ORG, ELECTRON_REPO, ElectronReleaseRepo, NIGHTLY_REPO } from '../types';
 

script/release/version-bumper.ts

@@ -2,7 +2,9 @@
 
 import { valid, coerce, inc } from 'semver';
 
-import { getElectronVersion } from '../lib/get-version';
+import { parseArgs } from 'node:util';
+
+import { VersionBumpType } from './types';
 import {
   isNightly,
   isAlpha,
@@ -12,8 +14,7 @@ import {
   nextBeta,
   isStable
 } from './version-utils';
-import { VersionBumpType } from './types';
-import { parseArgs } from 'node:util';
+import { getElectronVersion } from '../lib/get-version';
 
 // run the script
 async function main () {

script/release/version-utils.ts

@@ -1,5 +1,5 @@
-import * as semver from 'semver';
 import { GitProcess } from 'dugite';
+import * as semver from 'semver';
 
 import { ELECTRON_DIR } from '../lib/utils';