mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

feat: allow registering multiple shortcuts (#15542)

Browse source 
This PR allows for multiple global shortcuts to be registered such that triggering any of them calls the same callback.
This commit is contained in:
Shelley Vohr 2018-11-07 09:40:38 -08:00 • committed by GitHub
parent 20a540e680
commit e9ba26f50e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 61 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

21
spec/api-global-shortcut-spec.js
View file

@ -18,8 +18,8 @@ describe('globalShortcut module', () => {
globalShortcut.unregisterAll()
})
it('can register and unregister accelerators', () => {
const accelerator = 'CommandOrControl+A+B+C'
it('can register and unregister single accelerators', () => {
const accelerator = 'CmdOrCtrl+A+B+C'
expect(globalShortcut.isRegistered(accelerator)).to.be.false()
globalShortcut.register(accelerator, () => {})
@ -33,4 +33,21 @@ describe('globalShortcut module', () => {
globalShortcut.unregisterAll()
expect(globalShortcut.isRegistered(accelerator)).to.be.false()
})
it('can register and unregister multiple accelerators', () => {
const accelerators = ['CmdOrCtrl+X', 'CmdOrCtrl+Y']
expect(globalShortcut.isRegistered(accelerators[0])).to.be.false()
expect(globalShortcut.isRegistered(accelerators[1])).to.be.false()
globalShortcut.registerAll(accelerators, () => {})
expect(globalShortcut.isRegistered(accelerators[0])).to.be.true()
expect(globalShortcut.isRegistered(accelerators[1])).to.be.true()
globalShortcut.unregisterAll()
expect(globalShortcut.isRegistered(accelerators[0])).to.be.false()
expect(globalShortcut.isRegistered(accelerators[1])).to.be.false()
})
})