mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: setTopBrowserView focus issue with reordering (#42653)

Browse source 
* fix: reorder top browser view instead of adding/removing

* fix: update browserViews order

* test: add a test for setTopBrowserView
This commit is contained in:
Alice Zhao 2024-07-01 02:36:04 -07:00 • committed by GitHub
parent efff369639
commit e9a93a8c5c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 19 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

13
spec/api-browser-view-spec.ts
View file

@ -520,6 +520,19 @@ describe('BrowserView module', () => {
win2.close();
win2.destroy();
});
it('should reorder the BrowserView to the top if it is already in the window', () => {
view = new BrowserView();
const view2 = new BrowserView();
defer(() => view2.webContents.destroy());
w.addBrowserView(view);
w.addBrowserView(view2);
defer(() => w.removeBrowserView(view2));
w.setTopBrowserView(view);
const views = w.getBrowserViews();
expect(views.indexOf(view)).to.equal(views.length - 1);
});
});
describe('BrowserView.webContents.getOwnerBrowserWindow()', () => {