mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Partial revert of Provide WebContents::CreateParams to tab helpers.

Browse source 
https://chromium-review.googlesource.com/c/571285
This commit is contained in:
Aleksei Kuzmin 2017-08-21 00:59:37 +03:00 committed by Cheng Zhao
parent 9566904838
commit e926473e5a
2 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
atom/browser/api/atom_api_web_contents.cc
View file

@ -507,8 +507,7 @@ void WebContents::WebContentsCreated(
int opener_render_frame_id, int opener_render_frame_id,
const std::string& frame_name, const std::string& frame_name,
const GURL& target_url, const GURL& target_url,
content::WebContents* new_contents, content::WebContents* new_contents) {
const base::Optional<content::WebContents::CreateParams>& create_params) {
v8::Locker locker(isolate()); v8::Locker locker(isolate());
v8::HandleScope handle_scope(isolate()); v8::HandleScope handle_scope(isolate());
auto api_web_contents = CreateFrom(isolate(), new_contents, BROWSER_WINDOW); auto api_web_contents = CreateFrom(isolate(), new_contents, BROWSER_WINDOW);

3
atom/browser/api/atom_api_web_contents.h
View file

@ -254,8 +254,7 @@ class WebContents : public mate::TrackableObject<WebContents>,
int opener_render_frame_id, int opener_render_frame_id,
const std::string& frame_name, const std::string& frame_name,
const GURL& target_url, const GURL& target_url,
content::WebContents* new_contents, content::WebContents* new_contents)
const base::Optional<content::WebContents::CreateParams>& create_params)
override; override;
void AddNewContents(content::WebContents* source, void AddNewContents(content::WebContents* source,
content::WebContents* new_contents, content::WebContents* new_contents,