From 90bff4d9de42cdb94894daf93d30b0749ba8acd4 Mon Sep 17 00:00:00 2001 From: Felix Rieseberg Date: Fri, 16 Sep 2016 11:43:48 -0700 Subject: [PATCH 1/3] :wrench: Ensure correct types for commandLine This commit ensures that arguments passed to `appendSwitch` and `appendArgument` are turned into strings before passing them over to the binding. --- lib/browser/api/app.js | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/lib/browser/api/app.js b/lib/browser/api/app.js index c6ad57321ba..a3d227b0796 100644 --- a/lib/browser/api/app.js +++ b/lib/browser/api/app.js @@ -24,8 +24,20 @@ Object.assign(app, { return Menu.getApplicationMenu() }, commandLine: { - appendSwitch: bindings.appendSwitch, - appendArgument: bindings.appendArgument + appendSwitch() { + let castedArgs = [...arguments].map((arg) => { + return typeof arg !== 'string' ? `${arg}` : arg + }) + + return binding.appendSwitch(...castedArgs) + }, + appendArgument() { + let castedArgs = [...arguments].map((arg) => { + return typeof arg !== 'string' ? `${arg}` : arg + }) + + return binding.appendArgument(...castedArgs) + } } }) From 29fa48d8c31a9bb8828a7931df243412b65eef83 Mon Sep 17 00:00:00 2001 From: Felix Rieseberg Date: Fri, 16 Sep 2016 11:43:48 -0700 Subject: [PATCH 2/3] :wrench: Ensure correct types for commandLine This commit ensures that arguments passed to `appendSwitch` and `appendArgument` are turned into strings before passing them over to the binding. --- lib/browser/api/app.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/browser/api/app.js b/lib/browser/api/app.js index a3d227b0796..80837501ecb 100644 --- a/lib/browser/api/app.js +++ b/lib/browser/api/app.js @@ -24,15 +24,15 @@ Object.assign(app, { return Menu.getApplicationMenu() }, commandLine: { - appendSwitch() { - let castedArgs = [...arguments].map((arg) => { + appendSwitch (...args) { + const castedArgs = args.map((arg) => { return typeof arg !== 'string' ? `${arg}` : arg }) return binding.appendSwitch(...castedArgs) }, - appendArgument() { - let castedArgs = [...arguments].map((arg) => { + appendArgument (...args) { + const castedArgs = [...arguments].map((arg) => { return typeof arg !== 'string' ? `${arg}` : arg }) From 48fd2bd35fbaf229835a3ffa5af8631148826a7f Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Mon, 19 Sep 2016 09:31:49 -0700 Subject: [PATCH 3/3] binding -> bindings --- lib/browser/api/app.js | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/lib/browser/api/app.js b/lib/browser/api/app.js index 80837501ecb..167327c40b2 100644 --- a/lib/browser/api/app.js +++ b/lib/browser/api/app.js @@ -28,15 +28,13 @@ Object.assign(app, { const castedArgs = args.map((arg) => { return typeof arg !== 'string' ? `${arg}` : arg }) - - return binding.appendSwitch(...castedArgs) + return bindings.appendSwitch(...castedArgs) }, appendArgument (...args) { - const castedArgs = [...arguments].map((arg) => { + const castedArgs = args.map((arg) => { return typeof arg !== 'string' ? `${arg}` : arg }) - - return binding.appendArgument(...castedArgs) + return bindings.appendArgument(...castedArgs) } } })