From e8f33f51fbed6a4e803b9dbba0513c7cca1252c5 Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Fri, 5 Jun 2015 13:41:45 +0800 Subject: [PATCH] Use DefaultWebContentsDelegate in api::WebContents --- atom/browser/api/atom_api_web_contents.cc | 15 --------------- atom/browser/api/atom_api_web_contents.h | 9 +-------- 2 files changed, 1 insertion(+), 23 deletions(-) diff --git a/atom/browser/api/atom_api_web_contents.cc b/atom/browser/api/atom_api_web_contents.cc index e06d2b2419..ac96a64d49 100644 --- a/atom/browser/api/atom_api_web_contents.cc +++ b/atom/browser/api/atom_api_web_contents.cc @@ -21,7 +21,6 @@ #include "base/strings/string_util.h" #include "base/strings/utf_string_conversions.h" #include "brightray/browser/inspectable_web_contents.h" -#include "brightray/browser/media/media_stream_devices_controller.h" #include "content/public/browser/favicon_status.h" #include "content/public/browser/guest_host.h" #include "content/public/browser/navigation_details.h" @@ -223,20 +222,6 @@ void WebContents::EnumerateDirectory(content::WebContents* guest, web_dialog_helper_->EnumerateDirectory(guest, request_id, path); } -bool WebContents::CheckMediaAccessPermission(content::WebContents* web_contents, - const GURL& security_origin, - content::MediaStreamType type) { - return true; -} - -void WebContents::RequestMediaAccessPermission( - content::WebContents*, - const content::MediaStreamRequest& request, - const content::MediaResponseCallback& callback) { - brightray::MediaStreamDevicesController controller(request, callback); - controller.TakeAction(); -} - void WebContents::HandleKeyboardEvent( content::WebContents* source, const content::NativeWebKeyboardEvent& event) { diff --git a/atom/browser/api/atom_api_web_contents.h b/atom/browser/api/atom_api_web_contents.h index 062831577a..14de69fc90 100644 --- a/atom/browser/api/atom_api_web_contents.h +++ b/atom/browser/api/atom_api_web_contents.h @@ -51,7 +51,7 @@ struct SetSizeParams { class WebContents : public mate::EventEmitter, public content::BrowserPluginGuestDelegate, - public content::WebContentsDelegate, + public brightray::DefaultWebContentsDelegate, public content::WebContentsObserver, public content::GpuDataManagerObserver { public: @@ -157,13 +157,6 @@ class WebContents : public mate::EventEmitter, void EnumerateDirectory(content::WebContents* web_contents, int request_id, const base::FilePath& path) override; - bool CheckMediaAccessPermission(content::WebContents* web_contents, - const GURL& security_origin, - content::MediaStreamType type) override; - void RequestMediaAccessPermission( - content::WebContents*, - const content::MediaStreamRequest&, - const content::MediaResponseCallback&) override; void HandleKeyboardEvent( content::WebContents* source, const content::NativeWebKeyboardEvent& event) override;