mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: memory leak in BrowserWindow (#27621)

Browse source
This commit is contained in:
Jeremy Rose 2021-02-05 13:20:20 -08:00 • committed by GitHub
parent b6a91ef5df
commit e87803919b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 3 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

8
shell/browser/electron_browser_main_parts.h
View file

@ -75,11 +75,6 @@ class ElectronBrowserMainParts : public content::BrowserMainParts {
// Gets the exit code
int GetExitCode();
// Register a callback that should be destroyed before JavaScript environment
// gets destroyed.
// Returns a closure that can be used to remove |callback| from the list.
void RegisterDestructionCallback(base::OnceClosure callback);
// Returns the connection to GeolocationControl which can be
// used to enable the location services once per client.
device::mojom::GeolocationControl* GetGeolocationControl();
@ -162,9 +157,6 @@ class ElectronBrowserMainParts : public content::BrowserMainParts {
std::unique_ptr<ElectronExtensionsBrowserClient> extensions_browser_client_;
#endif
// List of callbacks should be executed before destroying JS env.
std::list<base::OnceClosure> destructors_;
mojo::Remote<device::mojom::GeolocationControl> geolocation_control_;
static ElectronBrowserMainParts* self_;