mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

test: test menu rendering accelerators (#44634)

Browse source 
* test: test menu rendering accelerators

* Update spec/api-menu-spec.ts

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

---------

Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
This commit is contained in:
Shelley Vohr 2025-05-06 20:09:35 +02:00 • committed by GitHub
commit e876cecbc7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 59 additions and 50 deletions
Download patch file Download diff file Expand all files Collapse all files

30
spec/api-menu-spec.ts
View file

@ -7,6 +7,7 @@ import { once } from 'node:events';
import * as path from 'node:path';
import { setTimeout } from 'node:timers/promises';
import { singleModifierCombinations } from './lib/accelerator-helpers';
import { ifit } from './lib/spec-helpers';
import { closeWindow } from './lib/window-helpers';
import { sortMenuItems } from '../lib/browser/api/menu-utils';
@ -927,19 +928,22 @@ describe('Menu module', function () {
w.show();
});
it('does not crash when rendering menu item with Super or meta accelerator', async () => {
const menu = Menu.buildFromTemplate([{
label: 'Test Super',
accelerator: 'Super+Ctrl+T'
}, {
label: 'Test Meta',
accelerator: 'Meta+Ctrl+T'
}]);
const menuWillClose = once(menu, 'menu-will-close');
menu.popup({ window: w });
menu.closePopup();
await menuWillClose;
});
const chunkSize = 10;
let chunkCount = 0;
const totalChunks = Math.ceil(singleModifierCombinations.length / chunkSize);
for (let i = 0; i < singleModifierCombinations.length; i += chunkSize) {
const chunk = singleModifierCombinations.slice(i, i + chunkSize);
it(`does not crash when rendering menu item with single accelerator combinations ${++chunkCount}/${totalChunks}`, async () => {
const menu = Menu.buildFromTemplate([
...chunk.map(combination => ({
label: `Test ${combination}`,
accelerator: combination
}))
]);
menu.popup({ window: w });
menu.closePopup();
});
}
});
describe('Menu.setApplicationMenu', () => {