mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

add warning when addTabbedWindow is called on self

Browse source
This commit is contained in:
Shelley Vohr 2018-02-26 14:47:36 -08:00
parent 53229e3d6c
commit e84d7c0cda
No known key found for this signature in database
GPG key ID: F13993A75599653C
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
atom/browser/native_window_mac.mm
View file

@ -1672,9 +1672,13 @@ void NativeWindowMac::ToggleTabBar() {
} }
void NativeWindowMac::AddTabbedWindow(NativeWindow* window) { void NativeWindowMac::AddTabbedWindow(NativeWindow* window) {
if (window_.get() == window->GetNativeWindow()) {
NSLog(@"Error: AddTabbedWindow cannot be called by a window on itself.");
} else {
if ([window_ respondsToSelector:@selector(addTabbedWindow:ordered:)]) { if ([window_ respondsToSelector:@selector(addTabbedWindow:ordered:)]) {
[window_ addTabbedWindow:window->GetNativeWindow() ordered:NSWindowAbove]; [window_ addTabbedWindow:window->GetNativeWindow() ordered:NSWindowAbove];
} }
}
} }
void NativeWindowMac::SetRenderWidgetHostOpaque(bool opaque) { void NativeWindowMac::SetRenderWidgetHostOpaque(bool opaque) {