mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: unify BrowserWindow.isVisible() logic cross-platform (#38242)

Browse source
This commit is contained in:
Shelley Vohr 2023-05-16 11:46:45 +02:00 • committed by GitHub
parent 9bd9d312f8
commit e83197669c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 23 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

12
spec/api-browser-window-spec.ts
View file

@ -1095,6 +1095,18 @@ describe('BrowserWindow module', () => {
});
});
describe('BrowserWindow.minimize()', () => {
// TODO(codebytere): Enable for Linux once maximize/minimize events work in CI.
ifit(process.platform !== 'linux')('should not be visible when the window is minimized', async () => {
const minimize = once(w, 'minimize');
w.minimize();
await minimize;
expect(w.isMinimized()).to.equal(true);
expect(w.isVisible()).to.equal(false);
});
});
describe('BrowserWindow.showInactive()', () => {
it('should not focus on window', () => {
w.showInactive();