mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

chore: update base::Bind in app module (#17925)

Browse source 
* chore: update base::Bind in app module

* fix lint
This commit is contained in:
Shelley Vohr 2019-04-26 21:42:56 -07:00 • committed by GitHub
parent 68f448ee73
commit e7ef374899
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 101 additions and 81 deletions
Download patch file Download diff file Expand all files Collapse all files

9
atom/common/api/event_emitter_caller.h
View file

@ -5,6 +5,7 @@
#ifndef ATOM_COMMON_API_EVENT_EMITTER_CALLER_H_
#define ATOM_COMMON_API_EVENT_EMITTER_CALLER_H_
#include <utility>
#include <vector>
#include "atom/common/native_mate_converters/string16_converter.h"
@ -42,10 +43,10 @@ template <typename StringType, typename... Args>
v8::Local<v8::Value> EmitEvent(v8::Isolate* isolate,
v8::Local<v8::Object> obj,
const StringType& name,
const Args&... args) {
Args&&... args) {
internal::ValueVector converted_args = {
StringToV8(isolate, name),
ConvertToV8(isolate, args)...,
ConvertToV8(isolate, std::forward<Args>(args))...,
};
return internal::CallMethodWithArgs(isolate, obj, "emit", &converted_args);
}
@ -55,9 +56,9 @@ template <typename... Args>
v8::Local<v8::Value> CustomEmit(v8::Isolate* isolate,
v8::Local<v8::Object> object,
const char* custom_emit,
const Args&... args) {
Args&&... args) {
internal::ValueVector converted_args = {
ConvertToV8(isolate, args)...,
ConvertToV8(isolate, std::forward<Args>(args))...,
};
return internal::CallMethodWithArgs(isolate, object, custom_emit,
&converted_args);