mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Add "Renderer" suffix in name when crashing in renderer process.

Browse source
This commit is contained in:
Cheng Zhao 2013-11-13 19:06:11 +08:00
parent 62f200d252
commit e7d25385b0
1 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
common/crash_reporter/crash_reporter_mac.mm
View file

@ -20,15 +20,16 @@ class ScopedCrashReporter {
ScopedCrashReporter() : is_browser_(!base::mac::IsBackgroundOnlyProcess()) { ScopedCrashReporter() : is_browser_(!base::mac::IsBackgroundOnlyProcess()) {
NSMutableDictionary* parameters = NSMutableDictionary* parameters =
[NSMutableDictionary dictionaryWithCapacity:4]; [NSMutableDictionary dictionaryWithCapacity:4];
[parameters setValue:@"Atom-Shell" forKey:@BREAKPAD_PRODUCT];
[parameters setValue:@"GitHub, Inc" forKey:@BREAKPAD_VENDOR]; [parameters setValue:@"GitHub, Inc" forKey:@BREAKPAD_VENDOR];
// Use application's version for crashes in browser.
if (is_browser_) { if (is_browser_) {
[parameters setValue:@"Atom-Shell" forKey:@BREAKPAD_PRODUCT];
// Use application's version for crashes in browser.
std::string version = atom::Browser::Get()->GetVersion(); std::string version = atom::Browser::Get()->GetVersion();
[parameters setValue:base::SysUTF8ToNSString(version) [parameters setValue:base::SysUTF8ToNSString(version)
forKey:@BREAKPAD_VERSION]; forKey:@BREAKPAD_VERSION];
} else { } else {
[parameters setValue:@"Atom-Shell Renderer" forKey:@BREAKPAD_PRODUCT];
[parameters setValue:@ATOM_VERSION_STRING forKey:@BREAKPAD_VERSION]; [parameters setValue:@ATOM_VERSION_STRING forKey:@BREAKPAD_VERSION];
} }
@ -49,6 +50,8 @@ class ScopedCrashReporter {
~ScopedCrashReporter() { if (breakpad_) BreakpadRelease(breakpad_); } ~ScopedCrashReporter() { if (breakpad_) BreakpadRelease(breakpad_); }
bool is_browser() const { return is_browser_; }
void SetKey(const std::string& key, const std::string& value) { void SetKey(const std::string& key, const std::string& value) {
BreakpadSetKeyValue(breakpad_, BreakpadSetKeyValue(breakpad_,
base::SysUTF8ToNSString(key), base::SysUTF8ToNSString(key),