mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fixes and tests for webview 'webpreferences' attr

Browse source
This commit is contained in:
Paul Frazee 2016-10-14 18:04:33 -05:00
parent 194b14100e
commit e7962c7ba2
3 changed files with 31 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
lib/browser/guest-view-manager.js
View file

@ -188,6 +188,7 @@ const attachGuest = function (embedder, elementInstanceId, guestInstanceId, para
// this uses the same parsing rules as window.open uses for its features
if (typeof params.webpreferences === 'string') {
// split the attribute's value by ','
let i, len
let webpreferencesTokens = params.webpreferences.split(/,\s*/)
for (i = 0, len = webpreferencesTokens.length; i < len; i++) {
// expected form is either a name by itself (true boolean flag)
@ -195,8 +196,8 @@ const attachGuest = function (embedder, elementInstanceId, guestInstanceId, para
// split the tokens by '='
let pref = webpreferencesTokens[i]
let prefTokens = pref.split(/\s*=/)
name = prefTokens[0]
value = prefTokens[1]
let name = prefTokens[0]
let value = prefTokens[1]
if (!name) continue
// interpret the value as a boolean, if possible