mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix: do not call after() async_hook for asyncId 0 (#40574)

Browse source 
fix: do not call after() async_hook for asyncId 0
This commit is contained in:
Shelley Vohr 2023-11-22 17:37:40 +01:00 committed by GitHub
parent 1574cbf137
commit e78ce82641
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
shell/common/node_bindings.cc
View file

@ -279,8 +279,11 @@ void ErrorMessageListener(v8::Local<v8::Message> message,
// Analogous to node/lib/internal/process/execution.js#L176-L180 // Analogous to node/lib/internal/process/execution.js#L176-L180
if (env->async_hooks()->fields()[node::AsyncHooks::kAfter]) { if (env->async_hooks()->fields()[node::AsyncHooks::kAfter]) {
while (env->async_hooks()->fields()[node::AsyncHooks::kStackLength]) { while (env->async_hooks()->fields()[node::AsyncHooks::kStackLength]) {
node::AsyncWrap::EmitAfter(env, env->execution_async_id()); double id = env->execution_async_id();
env->async_hooks()->pop_async_context(env->execution_async_id()); // Do not call EmitAfter for asyncId 0.
if (id != 0)
node::AsyncWrap::EmitAfter(env, id);
env->async_hooks()->pop_async_context(id);
} }
} }