Merge pull request #6190 from electron/default-label-and-accelerator

Add default label and accelerator for menu item roles
This commit is contained in:
Cheng Zhao 2016-06-23 05:34:10 +00:00 committed by GitHub
commit e70c622a70
8 changed files with 198 additions and 131 deletions

View file

@ -395,4 +395,32 @@ describe('menu module', function () {
}, /Invalid submenu/)
})
})
describe('MenuItem role', function () {
it('includes a default label and accelerator', function () {
var item = new MenuItem({role: 'close'})
assert.equal(item.label, 'Close')
assert.equal(item.accelerator, 'CommandOrControl+W')
var item = new MenuItem({role: 'close', label: 'Other'})
assert.equal(item.label, 'Other')
assert.equal(item.accelerator, 'CommandOrControl+W')
var item = new MenuItem({role: 'close', accelerator: 'D'})
assert.equal(item.label, 'Close')
assert.equal(item.accelerator, 'D')
var item = new MenuItem({role: 'close', label: 'C', accelerator: 'D'})
assert.equal(item.label, 'C')
assert.equal(item.accelerator, 'D')
var item = new MenuItem({role: 'help'})
assert.equal(item.label, 'Help')
assert.equal(item.accelerator, undefined)
var item = new MenuItem({role: 'hide'})
assert.equal(item.label, 'Hide Electron Test')
assert.equal(item.accelerator, 'Command+H')
})
})
})