mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix: free IsolateData in ~NodeEnvironment (#28469)

Browse source 
This seems to just have been missing here, leaking memory
(and breaking the API contract for Node.js embedding).
This commit is contained in:
Anna Henningsen 2021-04-02 01:46:11 +02:00 committed by GitHub
parent fa65faa4b0
commit e6aefed0ee
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
shell/browser/javascript_environment.cc
View file

@ -363,7 +363,9 @@ void JavascriptEnvironment::OnMessageLoopDestroying() {
NodeEnvironment::NodeEnvironment(node::Environment* env) : env_(env) {}
NodeEnvironment::~NodeEnvironment() {
auto* isolate_data = env_->isolate_data();
node::FreeEnvironment(env_);
node::FreeIsolateData(isolate_data);
}
} // namespace electron