mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

Make Notification factory function a member of NotificationPresenter so that we can create different types of notifications based on runtime conditions.

Browse source
This commit is contained in:
Ales Pergl 2017-01-10 16:34:41 +01:00
parent 0981807261
commit e6a30388da
12 changed files with 22 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

6
brightray/browser/linux/libnotify_notification.cc
View file

@ -55,12 +55,6 @@ void log_and_clear_error(GError* error, const char* context) {
} // namespace
// static
Notification* Notification::Create(NotificationDelegate* delegate,
NotificationPresenter* presenter) {
return new LibnotifyNotification(delegate, presenter);
}
// static
bool LibnotifyNotification::Initialize() {
if (!libnotify_loader_.Load("libnotify.so.4") && // most common one

4
brightray/browser/linux/notification_presenter_linux.cc
View file

@ -22,4 +22,8 @@ NotificationPresenterLinux::NotificationPresenterLinux() {
NotificationPresenterLinux::~NotificationPresenterLinux() {
}
Notification* NotificationPresenterLinux::CreateNotificationObject(NotificationDelegate* delegate) {
return new LibnotifyNotification(delegate, this);
}
} // namespace brightray

2
brightray/browser/linux/notification_presenter_linux.h
View file

@ -16,6 +16,8 @@ class NotificationPresenterLinux : public NotificationPresenter {
~NotificationPresenterLinux();
private:
Notification* CreateNotificationObject(NotificationDelegate* delegate) override;
DISALLOW_COPY_AND_ASSIGN(NotificationPresenterLinux);
};