mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

fix: correctly destroy spellcheck client (#16448)

Browse source 
* fix: Destroy spellcheck client

* Address review comments
This commit is contained in:
Nitish Sakhawalkar 2019-01-24 08:18:54 -08:00 • committed by Shelley Vohr
parent 1db4dd68a7
commit e6952e2a16
2 changed files with 27 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

4
atom/renderer/api/atom_api_web_frame.h
View file

@ -26,8 +26,6 @@ namespace atom {
namespace api {
class SpellCheckClient;
class WebFrame : public mate::Wrappable<WebFrame> {
public:
static mate::Handle<WebFrame> Create(v8::Isolate* isolate);
@ -97,8 +95,6 @@ class WebFrame : public mate::Wrappable<WebFrame> {
v8::Local<v8::Value> FindFrameByRoutingId(int routing_id) const;
v8::Local<v8::Value> RoutingId() const;
std::unique_ptr<SpellCheckClient> spell_check_client_;
blink::WebLocalFrame* web_frame_;
DISALLOW_COPY_AND_ASSIGN(WebFrame);