[chromium-style] override / virtual warnings

This commit is contained in:
Jeremy Apthorp 2018-04-17 16:03:51 -07:00
parent a635f078c6
commit e6695cf2ec
62 changed files with 106 additions and 106 deletions

View file

@ -16,7 +16,7 @@ namespace atom {
class AtomContentClient : public brightray::ContentClient { class AtomContentClient : public brightray::ContentClient {
public: public:
AtomContentClient(); AtomContentClient();
virtual ~AtomContentClient(); ~AtomContentClient() override;
protected: protected:
// content::ContentClient: // content::ContentClient:

View file

@ -15,7 +15,7 @@ namespace atom {
class AtomMainDelegate : public brightray::MainDelegate { class AtomMainDelegate : public brightray::MainDelegate {
public: public:
AtomMainDelegate(); AtomMainDelegate();
~AtomMainDelegate(); ~AtomMainDelegate() override;
protected: protected:
// content::ContentMainDelegate: // content::ContentMainDelegate:

View file

@ -34,7 +34,7 @@ class AutoUpdater : public mate::EventEmitter<AutoUpdater>,
void OnError(const std::string& error) override; void OnError(const std::string& error) override;
void OnError(const std::string& message, void OnError(const std::string& message,
const int code, const int code,
const std::string& domain); const std::string& domain) override;
void OnCheckingForUpdate() override; void OnCheckingForUpdate() override;
void OnUpdateAvailable() override; void OnUpdateAvailable() override;
void OnUpdateNotAvailable() override; void OnUpdateNotAvailable() override;

View file

@ -50,7 +50,7 @@ class DownloadItem : public mate::TrackableObject<DownloadItem>,
protected: protected:
DownloadItem(v8::Isolate* isolate, content::DownloadItem* download_item); DownloadItem(v8::Isolate* isolate, content::DownloadItem* download_item);
~DownloadItem(); ~DownloadItem() override;
// Override content::DownloadItem::Observer methods // Override content::DownloadItem::Observer methods
void OnDownloadUpdated(content::DownloadItem* download) override; void OnDownloadUpdated(content::DownloadItem* download) override;

View file

@ -47,7 +47,7 @@ class Protocol : public mate::TrackableObject<Protocol> {
protected: protected:
Protocol(v8::Isolate* isolate, AtomBrowserContext* browser_context); Protocol(v8::Isolate* isolate, AtomBrowserContext* browser_context);
~Protocol(); ~Protocol() override;
private: private:
// Possible errors. // Possible errors.

View file

@ -91,7 +91,7 @@ class Session : public mate::TrackableObject<Session>,
protected: protected:
Session(v8::Isolate* isolate, AtomBrowserContext* browser_context); Session(v8::Isolate* isolate, AtomBrowserContext* browser_context);
~Session(); ~Session() override;
// content::DownloadManager::Observer: // content::DownloadManager::Observer:
void OnDownloadCreated(content::DownloadManager* manager, void OnDownloadCreated(content::DownloadManager* manager,

View file

@ -262,7 +262,7 @@ class WebContents : public mate::TrackableObject<WebContents>,
content::WebContents* web_contents, content::WebContents* web_contents,
Type type); Type type);
WebContents(v8::Isolate* isolate, const mate::Dictionary& options); WebContents(v8::Isolate* isolate, const mate::Dictionary& options);
~WebContents(); ~WebContents() override;
void InitWithSessionAndOptions(v8::Isolate* isolate, void InitWithSessionAndOptions(v8::Isolate* isolate,
content::WebContents* web_contents, content::WebContents* web_contents,

View file

@ -32,7 +32,7 @@ class SavePageHandler : public content::DownloadManager::Observer,
SavePageHandler(content::WebContents* web_contents, SavePageHandler(content::WebContents* web_contents,
const SavePageCallback& callback); const SavePageCallback& callback);
~SavePageHandler(); ~SavePageHandler() override;
bool Handle(const base::FilePath& full_path, bool Handle(const base::FilePath& full_path,
const content::SavePageType& save_type); const content::SavePageType& save_type);

View file

@ -31,7 +31,7 @@ class AtomBrowserClient : public brightray::BrowserClient,
public content::RenderProcessHostObserver { public content::RenderProcessHostObserver {
public: public:
AtomBrowserClient(); AtomBrowserClient();
virtual ~AtomBrowserClient(); ~AtomBrowserClient() override;
using Delegate = content::ContentBrowserClient; using Delegate = content::ContentBrowserClient;
void set_delegate(Delegate* delegate) { delegate_ = delegate; } void set_delegate(Delegate* delegate) { delegate_ = delegate; }

View file

@ -28,7 +28,7 @@ class BridgeTaskRunner;
class AtomBrowserMainParts : public brightray::BrowserMainParts { class AtomBrowserMainParts : public brightray::BrowserMainParts {
public: public:
AtomBrowserMainParts(); AtomBrowserMainParts();
virtual ~AtomBrowserMainParts(); ~AtomBrowserMainParts() override;
static AtomBrowserMainParts* Get(); static AtomBrowserMainParts* Get();

View file

@ -22,7 +22,7 @@ class AtomDownloadManagerDelegate : public content::DownloadManagerDelegate {
base::Callback<void(const base::FilePath&)>; base::Callback<void(const base::FilePath&)>;
explicit AtomDownloadManagerDelegate(content::DownloadManager* manager); explicit AtomDownloadManagerDelegate(content::DownloadManager* manager);
virtual ~AtomDownloadManagerDelegate(); ~AtomDownloadManagerDelegate() override;
void OnDownloadPathGenerated(uint32_t download_id, void OnDownloadPathGenerated(uint32_t download_id,
const content::DownloadTargetCallback& callback, const content::DownloadTargetCallback& callback,

View file

@ -18,7 +18,7 @@ class AtomSpeechRecognitionManagerDelegate
public content::SpeechRecognitionEventListener { public content::SpeechRecognitionEventListener {
public: public:
AtomSpeechRecognitionManagerDelegate(); AtomSpeechRecognitionManagerDelegate();
virtual ~AtomSpeechRecognitionManagerDelegate(); ~AtomSpeechRecognitionManagerDelegate() override;
// content::SpeechRecognitionEventListener: // content::SpeechRecognitionEventListener:
void OnRecognitionStart(int session_id) override; void OnRecognitionStart(int session_id) override;

View file

@ -16,7 +16,7 @@ class AtomWebUIControllerFactory : public content::WebUIControllerFactory {
static AtomWebUIControllerFactory* GetInstance(); static AtomWebUIControllerFactory* GetInstance();
AtomWebUIControllerFactory(); AtomWebUIControllerFactory();
virtual ~AtomWebUIControllerFactory(); ~AtomWebUIControllerFactory() override;
// content::WebUIControllerFactory: // content::WebUIControllerFactory:
content::WebUI::TypeID GetWebUIType(content::BrowserContext* browser_context, content::WebUI::TypeID GetWebUIType(content::BrowserContext* browser_context,

View file

@ -38,7 +38,7 @@ class LoginHandler;
class Browser : public WindowListObserver { class Browser : public WindowListObserver {
public: public:
Browser(); Browser();
~Browser(); ~Browser() override;
static Browser* Get(); static Browser* Get();

View file

@ -33,7 +33,7 @@ class CommonWebContentsDelegate
public brightray::InspectableWebContentsViewDelegate { public brightray::InspectableWebContentsViewDelegate {
public: public:
CommonWebContentsDelegate(); CommonWebContentsDelegate();
virtual ~CommonWebContentsDelegate(); ~CommonWebContentsDelegate() override;
// Creates a InspectableWebContents object and takes onwership of // Creates a InspectableWebContents object and takes onwership of
// |web_contents|. // |web_contents|.

View file

@ -119,8 +119,8 @@ class NativeWindowMac : public NativeWindow {
void RefreshTouchBarItem(const std::string& item_id) override; void RefreshTouchBarItem(const std::string& item_id) override;
void SetEscapeTouchBarItem(const mate::PersistentDictionary& item) override; void SetEscapeTouchBarItem(const mate::PersistentDictionary& item) override;
gfx::Rect ContentBoundsToWindowBounds(const gfx::Rect& bounds) const; gfx::Rect ContentBoundsToWindowBounds(const gfx::Rect& bounds) const override;
gfx::Rect WindowBoundsToContentBounds(const gfx::Rect& bounds) const; gfx::Rect WindowBoundsToContentBounds(const gfx::Rect& bounds) const override;
// Set the attribute of NSWindow while work around a bug of zoom button. // Set the attribute of NSWindow while work around a bug of zoom button.
void SetStyleMask(bool on, NSUInteger flag); void SetStyleMask(bool on, NSUInteger flag);

View file

@ -18,7 +18,7 @@ class AsarProtocolHandler : public net::URLRequestJobFactory::ProtocolHandler {
public: public:
explicit AsarProtocolHandler( explicit AsarProtocolHandler(
const scoped_refptr<base::TaskRunner>& file_task_runner); const scoped_refptr<base::TaskRunner>& file_task_runner);
virtual ~AsarProtocolHandler(); ~AsarProtocolHandler() override;
// net::URLRequestJobFactory::ProtocolHandler: // net::URLRequestJobFactory::ProtocolHandler:
net::URLRequestJob* MaybeCreateJob( net::URLRequestJob* MaybeCreateJob(

View file

@ -42,7 +42,7 @@ class URLRequestAsarJob : public net::URLRequestJob {
const base::FilePath& file_path); const base::FilePath& file_path);
protected: protected:
virtual ~URLRequestAsarJob(); ~URLRequestAsarJob() override;
void InitializeAsarJob(const scoped_refptr<base::TaskRunner> file_task_runner, void InitializeAsarJob(const scoped_refptr<base::TaskRunner> file_task_runner,
std::shared_ptr<Archive> archive, std::shared_ptr<Archive> archive,

View file

@ -31,7 +31,7 @@ struct VerifyRequestParams {
class AtomCertVerifier : public net::CertVerifier { class AtomCertVerifier : public net::CertVerifier {
public: public:
explicit AtomCertVerifier(brightray::RequireCTDelegate* ct_delegate); explicit AtomCertVerifier(brightray::RequireCTDelegate* ct_delegate);
virtual ~AtomCertVerifier(); ~AtomCertVerifier() override;
using VerifyProc = base::Callback<void(const VerifyRequestParams& request, using VerifyProc = base::Callback<void(const VerifyRequestParams& request,
const net::CompletionCallback&)>; const net::CompletionCallback&)>;

View file

@ -21,7 +21,7 @@ const void* DisableProtocolInterceptFlagKey();
class AtomURLRequestJobFactory : public net::URLRequestJobFactory { class AtomURLRequestJobFactory : public net::URLRequestJobFactory {
public: public:
AtomURLRequestJobFactory(); AtomURLRequestJobFactory();
virtual ~AtomURLRequestJobFactory(); ~AtomURLRequestJobFactory() override;
// Sets the ProtocolHandler for a scheme. Returns true on success, false on // Sets the ProtocolHandler for a scheme. Returns true on success, false on
// failure (a ProtocolHandler already exists for |scheme|). On success, // failure (a ProtocolHandler already exists for |scheme|). On success,

View file

@ -14,7 +14,7 @@ namespace atom {
class HttpProtocolHandler : public net::URLRequestJobFactory::ProtocolHandler { class HttpProtocolHandler : public net::URLRequestJobFactory::ProtocolHandler {
public: public:
explicit HttpProtocolHandler(const std::string&); explicit HttpProtocolHandler(const std::string&);
virtual ~HttpProtocolHandler(); ~HttpProtocolHandler() override;
// net::URLRequestJobFactory::ProtocolHandler: // net::URLRequestJobFactory::ProtocolHandler:
net::URLRequestJob* MaybeCreateJob( net::URLRequestJob* MaybeCreateJob(

View file

@ -27,7 +27,7 @@ class RenderProcessPreferences : public content::NotificationObserver {
// The |predicate| is used to determine whether to set preferences for a // The |predicate| is used to determine whether to set preferences for a
// render process. // render process.
explicit RenderProcessPreferences(const Predicate& predicate); explicit RenderProcessPreferences(const Predicate& predicate);
virtual ~RenderProcessPreferences(); ~RenderProcessPreferences() override;
int AddEntry(const base::DictionaryValue& entry); int AddEntry(const base::DictionaryValue& entry);
void RemoveEntry(int id); void RemoveEntry(int id);

View file

@ -16,7 +16,7 @@ class AtomMenuModel : public ui::SimpleMenuModel {
public: public:
class Delegate : public ui::SimpleMenuModel::Delegate { class Delegate : public ui::SimpleMenuModel::Delegate {
public: public:
virtual ~Delegate() {} ~Delegate() override {}
virtual bool GetAcceleratorForCommandIdWithParams( virtual bool GetAcceleratorForCommandIdWithParams(
int command_id, int command_id,
@ -44,7 +44,7 @@ class AtomMenuModel : public ui::SimpleMenuModel {
}; };
explicit AtomMenuModel(Delegate* delegate); explicit AtomMenuModel(Delegate* delegate);
virtual ~AtomMenuModel(); ~AtomMenuModel() override;
void AddObserver(Observer* obs) { observers_.AddObserver(obs); } void AddObserver(Observer* obs) { observers_.AddObserver(obs); }
void RemoveObserver(Observer* obs) { observers_.RemoveObserver(obs); } void RemoveObserver(Observer* obs) { observers_.RemoveObserver(obs); }

View file

@ -21,7 +21,7 @@ class AutofillPopupView;
class AutofillPopup : public views::ViewObserver { class AutofillPopup : public views::ViewObserver {
public: public:
AutofillPopup(); AutofillPopup();
~AutofillPopup(); ~AutofillPopup() override;
void CreateView(content::RenderFrameHost* render_frame, void CreateView(content::RenderFrameHost* render_frame,
bool offscreen, bool offscreen,

View file

@ -20,7 +20,7 @@ namespace atom {
class TrayIconCocoa : public TrayIcon, public AtomMenuModel::Observer { class TrayIconCocoa : public TrayIcon, public AtomMenuModel::Observer {
public: public:
TrayIconCocoa(); TrayIconCocoa();
virtual ~TrayIconCocoa(); ~TrayIconCocoa() override;
void SetImage(const gfx::Image& image) override; void SetImage(const gfx::Image& image) override;
void SetPressedImage(const gfx::Image& image) override; void SetPressedImage(const gfx::Image& image) override;

View file

@ -45,7 +45,7 @@ class CrashReporterMac : public CrashReporter {
friend struct base::DefaultSingletonTraits<CrashReporterMac>; friend struct base::DefaultSingletonTraits<CrashReporterMac>;
CrashReporterMac(); CrashReporterMac();
virtual ~CrashReporterMac(); ~CrashReporterMac() override;
void SetUploadsEnabled(bool enable_uploads); void SetUploadsEnabled(bool enable_uploads);
void SetCrashKeyValue(const base::StringPiece& key, void SetCrashKeyValue(const base::StringPiece& key,

View file

@ -13,7 +13,7 @@ namespace atom {
class NodeBindingsMac : public NodeBindings { class NodeBindingsMac : public NodeBindings {
public: public:
explicit NodeBindingsMac(BrowserEnvironment browser_env); explicit NodeBindingsMac(BrowserEnvironment browser_env);
virtual ~NodeBindingsMac(); ~NodeBindingsMac() override;
void RunMessageLoop() override; void RunMessageLoop() override;

View file

@ -33,7 +33,7 @@ class SpellCheckClient : public blink::WebSpellCheckPanelHostClient,
bool auto_spell_correct_turned_on, bool auto_spell_correct_turned_on,
v8::Isolate* isolate, v8::Isolate* isolate,
v8::Local<v8::Object> provider); v8::Local<v8::Object> provider);
virtual ~SpellCheckClient(); ~SpellCheckClient() override;
private: private:
class SpellcheckRequest; class SpellcheckRequest;

View file

@ -14,7 +14,7 @@ class AtomRenderViewObserver : public content::RenderViewObserver {
explicit AtomRenderViewObserver(content::RenderView* render_view); explicit AtomRenderViewObserver(content::RenderView* render_view);
protected: protected:
virtual ~AtomRenderViewObserver(); ~AtomRenderViewObserver() override;
private: private:
// content::RenderViewObserver implementation. // content::RenderViewObserver implementation.

View file

@ -23,7 +23,7 @@ class NodeBindings;
class AtomRendererClient : public RendererClientBase { class AtomRendererClient : public RendererClientBase {
public: public:
AtomRendererClient(); AtomRendererClient();
virtual ~AtomRendererClient(); ~AtomRendererClient() override;
// atom::RendererClientBase: // atom::RendererClientBase:
void DidCreateScriptContext(v8::Handle<v8::Context> context, void DidCreateScriptContext(v8::Handle<v8::Context> context,

View file

@ -107,7 +107,7 @@ class AtomSandboxedRenderFrameObserver : public AtomRenderFrameObserver {
protected: protected:
void EmitIPCEvent(blink::WebLocalFrame* frame, void EmitIPCEvent(blink::WebLocalFrame* frame,
const base::string16& channel, const base::string16& channel,
const base::ListValue& args) { const base::ListValue& args) override {
if (!frame) if (!frame)
return; return;

View file

@ -14,7 +14,7 @@ namespace atom {
class AtomSandboxedRendererClient : public RendererClientBase { class AtomSandboxedRendererClient : public RendererClientBase {
public: public:
AtomSandboxedRendererClient(); AtomSandboxedRendererClient();
virtual ~AtomSandboxedRendererClient(); ~AtomSandboxedRendererClient() override;
void InvokeIpcCallback(v8::Handle<v8::Context> context, void InvokeIpcCallback(v8::Handle<v8::Context> context,
const std::string& callback_name, const std::string& callback_name,

View file

@ -18,7 +18,7 @@ class PreferencesManager;
class RendererClientBase : public content::ContentRendererClient { class RendererClientBase : public content::ContentRendererClient {
public: public:
RendererClientBase(); RendererClientBase();
virtual ~RendererClientBase(); ~RendererClientBase() override;
virtual void DidCreateScriptContext(v8::Handle<v8::Context> context, virtual void DidCreateScriptContext(v8::Handle<v8::Context> context,
content::RenderFrame* render_frame) = 0; content::RenderFrame* render_frame) = 0;

View file

@ -23,7 +23,7 @@ class BrowserClient : public content::ContentBrowserClient {
static void SetApplicationLocale(const std::string& locale); static void SetApplicationLocale(const std::string& locale);
BrowserClient(); BrowserClient();
~BrowserClient(); ~BrowserClient() override;
BrowserMainParts* browser_main_parts() { return browser_main_parts_; } BrowserMainParts* browser_main_parts() { return browser_main_parts_; }

View file

@ -33,7 +33,7 @@ namespace brightray {
class BrowserMainParts : public content::BrowserMainParts { class BrowserMainParts : public content::BrowserMainParts {
public: public:
BrowserMainParts(); BrowserMainParts();
~BrowserMainParts(); ~BrowserMainParts() override;
IOThread* io_thread() const { return io_thread_.get(); } IOThread* io_thread() const { return io_thread_.get(); }

View file

@ -18,7 +18,7 @@ class DevToolsManagerDelegate : public content::DevToolsManagerDelegate {
static void StartHttpHandler(); static void StartHttpHandler();
DevToolsManagerDelegate(); DevToolsManagerDelegate();
virtual ~DevToolsManagerDelegate(); ~DevToolsManagerDelegate() override;
// DevToolsManagerDelegate implementation. // DevToolsManagerDelegate implementation.
void Inspect(content::DevToolsAgentHost* agent_host) override; void Inspect(content::DevToolsAgentHost* agent_host) override;

View file

@ -40,7 +40,7 @@ class InspectableWebContentsImpl
static void RegisterPrefs(PrefRegistrySimple* pref_registry); static void RegisterPrefs(PrefRegistrySimple* pref_registry);
explicit InspectableWebContentsImpl(content::WebContents*); explicit InspectableWebContentsImpl(content::WebContents*);
virtual ~InspectableWebContentsImpl(); ~InspectableWebContentsImpl() override;
InspectableWebContentsView* GetView() const override; InspectableWebContentsView* GetView() const override;
content::WebContents* GetWebContents() const override; content::WebContents* GetWebContents() const override;

View file

@ -15,7 +15,7 @@ class InspectableWebContentsViewMac : public InspectableWebContentsView {
public: public:
explicit InspectableWebContentsViewMac( explicit InspectableWebContentsViewMac(
InspectableWebContentsImpl* inspectable_web_contents_impl); InspectableWebContentsImpl* inspectable_web_contents_impl);
virtual ~InspectableWebContentsViewMac(); ~InspectableWebContentsViewMac() override;
gfx::NativeView GetNativeView() const override; gfx::NativeView GetNativeView() const override;
void ShowDevTools() override; void ShowDevTools() override;

View file

@ -18,7 +18,7 @@ class LibnotifyNotification : public Notification {
public: public:
LibnotifyNotification(NotificationDelegate* delegate, LibnotifyNotification(NotificationDelegate* delegate,
NotificationPresenter* presenter); NotificationPresenter* presenter);
virtual ~LibnotifyNotification(); ~LibnotifyNotification() override;
static bool Initialize(); static bool Initialize();

View file

@ -13,7 +13,7 @@ namespace brightray {
class NotificationPresenterLinux : public NotificationPresenter { class NotificationPresenterLinux : public NotificationPresenter {
public: public:
NotificationPresenterLinux(); NotificationPresenterLinux();
~NotificationPresenterLinux(); ~NotificationPresenterLinux() override;
private: private:
Notification* CreateNotificationObject( Notification* CreateNotificationObject(

View file

@ -20,7 +20,7 @@ class CocoaNotification : public Notification {
public: public:
CocoaNotification(NotificationDelegate* delegate, CocoaNotification(NotificationDelegate* delegate,
NotificationPresenter* presenter); NotificationPresenter* presenter);
~CocoaNotification(); ~CocoaNotification() override;
// Notification: // Notification:
void Show(const NotificationOptions& options) override; void Show(const NotificationOptions& options) override;

View file

@ -19,7 +19,7 @@ class NotificationPresenterMac : public NotificationPresenter {
CocoaNotification* GetNotification(NSUserNotification* notif); CocoaNotification* GetNotification(NSUserNotification* notif);
NotificationPresenterMac(); NotificationPresenterMac();
~NotificationPresenterMac(); ~NotificationPresenterMac() override;
private: private:
Notification* CreateNotificationObject( Notification* CreateNotificationObject(

View file

@ -70,7 +70,7 @@ class MediaCaptureDevicesDispatcher : public content::MediaObserver {
friend struct base::DefaultSingletonTraits<MediaCaptureDevicesDispatcher>; friend struct base::DefaultSingletonTraits<MediaCaptureDevicesDispatcher>;
MediaCaptureDevicesDispatcher(); MediaCaptureDevicesDispatcher();
virtual ~MediaCaptureDevicesDispatcher(); ~MediaCaptureDevicesDispatcher() override;
// Flag used by unittests to disable device enumeration. // Flag used by unittests to disable device enumeration.
bool is_device_enumeration_disabled_; bool is_device_enumeration_disabled_;

View file

@ -15,7 +15,7 @@ namespace brightray {
class NetworkDelegate : public net::NetworkDelegate { class NetworkDelegate : public net::NetworkDelegate {
public: public:
NetworkDelegate(); NetworkDelegate();
virtual ~NetworkDelegate(); ~NetworkDelegate() override;
protected: protected:
int OnBeforeURLRequest(net::URLRequest* request, int OnBeforeURLRequest(net::URLRequest* request,

View file

@ -73,7 +73,7 @@ class URLRequestContextGetter : public net::URLRequestContextGetter {
scoped_refptr<base::SingleThreadTaskRunner> io_task_runner, scoped_refptr<base::SingleThreadTaskRunner> io_task_runner,
content::ProtocolHandlerMap* protocol_handlers, content::ProtocolHandlerMap* protocol_handlers,
content::URLRequestInterceptorScopedVector protocol_interceptors); content::URLRequestInterceptorScopedVector protocol_interceptors);
virtual ~URLRequestContextGetter(); ~URLRequestContextGetter() override;
// net::CookieStore::CookieChangedCallback implementation. // net::CookieStore::CookieChangedCallback implementation.
void OnCookieChanged(const net::CanonicalCookie& cookie, void OnCookieChanged(const net::CanonicalCookie& cookie,

View file

@ -30,7 +30,7 @@ class DevToolsWindowDelegate : public views::ClientView,
if (shell->GetDelegate()) if (shell->GetDelegate())
icon_ = shell->GetDelegate()->GetDevToolsWindowIcon(); icon_ = shell->GetDelegate()->GetDevToolsWindowIcon();
} }
virtual ~DevToolsWindowDelegate() {} ~DevToolsWindowDelegate() override {}
// views::WidgetDelegate: // views::WidgetDelegate:
void DeleteDelegate() override { delete this; } void DeleteDelegate() override { delete this; }

View file

@ -21,7 +21,7 @@ class InspectableWebContentsViewViews : public InspectableWebContentsView,
public: public:
explicit InspectableWebContentsViewViews( explicit InspectableWebContentsViewViews(
InspectableWebContentsImpl* inspectable_web_contents_impl); InspectableWebContentsImpl* inspectable_web_contents_impl);
~InspectableWebContentsViewViews(); ~InspectableWebContentsViewViews() override;
// InspectableWebContentsView: // InspectableWebContentsView:
views::View* GetView() override; views::View* GetView() override;

View file

@ -15,7 +15,7 @@ namespace brightray {
class ViewsDelegate : public views::ViewsDelegate { class ViewsDelegate : public views::ViewsDelegate {
public: public:
ViewsDelegate(); ViewsDelegate();
virtual ~ViewsDelegate(); ~ViewsDelegate() override;
protected: protected:
// views::ViewsDelegate: // views::ViewsDelegate:

View file

@ -23,7 +23,7 @@ class WebUIControllerFactory : public content::WebUIControllerFactory {
static WebUIControllerFactory* GetInstance(); static WebUIControllerFactory* GetInstance();
WebUIControllerFactory(); WebUIControllerFactory();
virtual ~WebUIControllerFactory(); ~WebUIControllerFactory() override;
content::WebUI::TypeID GetWebUIType(content::BrowserContext* browser_context, content::WebUI::TypeID GetWebUIType(content::BrowserContext* browser_context,
const GURL& url) const override; const GURL& url) const override;

View file

@ -17,7 +17,7 @@ std::string GetBrightrayUserAgent();
class ContentClient : public content::ContentClient { class ContentClient : public content::ContentClient {
public: public:
ContentClient(); ContentClient();
~ContentClient(); ~ContentClient() override;
private: private:
std::string GetProduct() const override; std::string GetProduct() const override;

View file

@ -30,7 +30,7 @@ void LoadCommonResources();
class MainDelegate : public content::ContentMainDelegate { class MainDelegate : public content::ContentMainDelegate {
public: public:
MainDelegate(); MainDelegate();
~MainDelegate(); ~MainDelegate() override;
protected: protected:
// Subclasses can override this to provide their own ContentClient // Subclasses can override this to provide their own ContentClient

View file

@ -29,7 +29,7 @@ namespace extensions {
class GlobalShortcutListenerMac : public GlobalShortcutListener { class GlobalShortcutListenerMac : public GlobalShortcutListener {
public: public:
GlobalShortcutListenerMac(); GlobalShortcutListenerMac();
virtual ~GlobalShortcutListenerMac(); ~GlobalShortcutListenerMac() override;
private: private:
typedef int KeyId; typedef int KeyId;
@ -42,11 +42,11 @@ class GlobalShortcutListenerMac : public GlobalShortcutListener {
bool OnMediaOrVolumeKeyEvent(int key_code); bool OnMediaOrVolumeKeyEvent(int key_code);
// GlobalShortcutListener implementation. // GlobalShortcutListener implementation.
virtual void StartListening() override; void StartListening() override;
virtual void StopListening() override; void StopListening() override;
virtual bool RegisterAcceleratorImpl( bool RegisterAcceleratorImpl(
const ui::Accelerator& accelerator) override; const ui::Accelerator& accelerator) override;
virtual void UnregisterAcceleratorImpl( void UnregisterAcceleratorImpl(
const ui::Accelerator& accelerator) override; const ui::Accelerator& accelerator) override;
// Mac-specific functions for registering hot keys with modifiers. // Mac-specific functions for registering hot keys with modifiers.

View file

@ -34,7 +34,7 @@ class PrintQueriesQueue;
class PrintViewManagerBase : public content::NotificationObserver, class PrintViewManagerBase : public content::NotificationObserver,
public content::WebContentsObserver { public content::WebContentsObserver {
public: public:
virtual ~PrintViewManagerBase(); ~PrintViewManagerBase() override;
#if !defined(DISABLE_BASIC_PRINTING) #if !defined(DISABLE_BASIC_PRINTING)
// Prints the current document immediately. Since the rendering is // Prints the current document immediately. Since the rendering is
@ -70,12 +70,12 @@ class PrintViewManagerBase : public content::NotificationObserver,
private: private:
// content::NotificationObserver implementation. // content::NotificationObserver implementation.
virtual void Observe(int type, void Observe(int type,
const content::NotificationSource& source, const content::NotificationSource& source,
const content::NotificationDetails& details) override; const content::NotificationDetails& details) override;
// Cancels the print job. // Cancels the print job.
virtual void NavigationStopped() override; void NavigationStopped() override;
// IPC Message handlers. // IPC Message handlers.
void OnDidGetPrintedPagesCount(int cookie, int number_pages); void OnDidGetPrintedPagesCount(int cookie, int number_pages);

View file

@ -19,7 +19,7 @@ class PrintViewManagerBasic
: public PrintViewManagerBase, : public PrintViewManagerBase,
public content::WebContentsUserData<PrintViewManagerBasic> { public content::WebContentsUserData<PrintViewManagerBasic> {
public: public:
virtual ~PrintViewManagerBasic(); ~PrintViewManagerBasic() override;
#if defined(OS_ANDROID) #if defined(OS_ANDROID)
// Sets the file descriptor into which the PDF will be written. // Sets the file descriptor into which the PDF will be written.

View file

@ -41,7 +41,7 @@ class PrintingMessageFilter : public content::BrowserMessageFilter {
friend class base::DeleteHelper<PrintingMessageFilter>; friend class base::DeleteHelper<PrintingMessageFilter>;
friend class content::BrowserThread; friend class content::BrowserThread;
virtual ~PrintingMessageFilter(); ~PrintingMessageFilter() override;
void OnDestruct() const override; void OnDestruct() const override;

View file

@ -24,7 +24,7 @@ class WidevineCdmMessageFilter : public content::BrowserMessageFilter {
friend class content::BrowserThread; friend class content::BrowserThread;
friend class base::DeleteHelper<WidevineCdmMessageFilter>; friend class base::DeleteHelper<WidevineCdmMessageFilter>;
virtual ~WidevineCdmMessageFilter(); ~WidevineCdmMessageFilter() override;
#if BUILDFLAG(ENABLE_LIBRARY_CDMS) #if BUILDFLAG(ENABLE_LIBRARY_CDMS)
// Returns whether any internal plugin supporting |mime_type| is registered // Returns whether any internal plugin supporting |mime_type| is registered

View file

@ -29,30 +29,30 @@ class TtsControllerImpl : public TtsController {
static TtsControllerImpl* GetInstance(); static TtsControllerImpl* GetInstance();
// TtsController methods // TtsController methods
virtual bool IsSpeaking() override; bool IsSpeaking() override;
virtual void SpeakOrEnqueue(Utterance* utterance) override; void SpeakOrEnqueue(Utterance* utterance) override;
virtual void Stop() override; void Stop() override;
virtual void Pause() override; void Pause() override;
virtual void Resume() override; void Resume() override;
virtual void OnTtsEvent(int utterance_id, void OnTtsEvent(int utterance_id,
TtsEventType event_type, TtsEventType event_type,
int char_index, int char_index,
const std::string& error_message) override; const std::string& error_message) override;
virtual void GetVoices(content::BrowserContext* browser_context, void GetVoices(content::BrowserContext* browser_context,
std::vector<VoiceData>* out_voices) override; std::vector<VoiceData>* out_voices) override;
virtual void VoicesChanged() override; void VoicesChanged() override;
virtual void AddVoicesChangedDelegate( void AddVoicesChangedDelegate(
VoicesChangedDelegate* delegate) override; VoicesChangedDelegate* delegate) override;
virtual void RemoveVoicesChangedDelegate( void RemoveVoicesChangedDelegate(
VoicesChangedDelegate* delegate) override; VoicesChangedDelegate* delegate) override;
virtual void SetTtsEngineDelegate(TtsEngineDelegate* delegate) override; void SetTtsEngineDelegate(TtsEngineDelegate* delegate) override;
virtual TtsEngineDelegate* GetTtsEngineDelegate() override; TtsEngineDelegate* GetTtsEngineDelegate() override;
virtual void SetPlatformImpl(TtsPlatformImpl* platform_impl) override; void SetPlatformImpl(TtsPlatformImpl* platform_impl) override;
virtual int QueueSize() override; int QueueSize() override;
protected: protected:
TtsControllerImpl(); TtsControllerImpl();
virtual ~TtsControllerImpl(); ~TtsControllerImpl() override;
private: private:
// Get the platform TTS implementation (or injected mock). // Get the platform TTS implementation (or injected mock).

View file

@ -49,26 +49,26 @@ class TtsPlatformImplMac;
class TtsPlatformImplMac : public TtsPlatformImpl { class TtsPlatformImplMac : public TtsPlatformImpl {
public: public:
virtual bool PlatformImplAvailable() override { bool PlatformImplAvailable() override {
return true; return true;
} }
virtual bool Speak( bool Speak(
int utterance_id, int utterance_id,
const std::string& utterance, const std::string& utterance,
const std::string& lang, const std::string& lang,
const VoiceData& voice, const VoiceData& voice,
const UtteranceContinuousParameters& params) override; const UtteranceContinuousParameters& params) override;
virtual bool StopSpeaking() override; bool StopSpeaking() override;
virtual void Pause() override; void Pause() override;
virtual void Resume() override; void Resume() override;
virtual bool IsSpeaking() override; bool IsSpeaking() override;
virtual void GetVoices(std::vector<VoiceData>* out_voices) override; void GetVoices(std::vector<VoiceData>* out_voices) override;
// Called by ChromeTtsDelegate when we get a callback from the // Called by ChromeTtsDelegate when we get a callback from the
// native speech engine. // native speech engine.
@ -82,7 +82,7 @@ class TtsPlatformImplMac : public TtsPlatformImpl {
private: private:
TtsPlatformImplMac(); TtsPlatformImplMac();
virtual ~TtsPlatformImplMac(); ~TtsPlatformImplMac() override;
base::scoped_nsobject<SingleUseSpeechSynthesizer> speech_synthesizer_; base::scoped_nsobject<SingleUseSpeechSynthesizer> speech_synthesizer_;
base::scoped_nsobject<ChromeTtsDelegate> delegate_; base::scoped_nsobject<ChromeTtsDelegate> delegate_;

View file

@ -41,7 +41,7 @@ class TtsMessageFilter : public content::BrowserMessageFilter,
friend class content::BrowserThread; friend class content::BrowserThread;
friend class base::DeleteHelper<TtsMessageFilter>; friend class base::DeleteHelper<TtsMessageFilter>;
virtual ~TtsMessageFilter(); ~TtsMessageFilter() override;
void OnInitializeVoiceList(); void OnInitializeVoiceList();
void OnSpeak(const TtsUtteranceRequest& utterance); void OnSpeak(const TtsUtteranceRequest& utterance);

View file

@ -39,14 +39,14 @@ class ColorChooserMac : public content::ColorChooser {
SkColor initial_color); SkColor initial_color);
ColorChooserMac(content::WebContents* tab, SkColor initial_color); ColorChooserMac(content::WebContents* tab, SkColor initial_color);
virtual ~ColorChooserMac(); ~ColorChooserMac() override;
// Called from ColorPanelCocoa. // Called from ColorPanelCocoa.
void DidChooseColorInColorPanel(SkColor color); void DidChooseColorInColorPanel(SkColor color);
void DidCloseColorPabel(); void DidCloseColorPabel();
virtual void End() override; void End() override;
virtual void SetSelectedColor(SkColor color) override; void SetSelectedColor(SkColor color) override;
private: private:
static ColorChooserMac* current_color_chooser_; static ColorChooserMac* current_color_chooser_;

View file

@ -67,7 +67,7 @@ class PrintWebViewHelper
public content::RenderFrameObserverTracker<PrintWebViewHelper> { public content::RenderFrameObserverTracker<PrintWebViewHelper> {
public: public:
explicit PrintWebViewHelper(content::RenderFrame* render_frame); explicit PrintWebViewHelper(content::RenderFrame* render_frame);
virtual ~PrintWebViewHelper(); ~PrintWebViewHelper() override;
void PrintNode(const blink::WebNode& node); void PrintNode(const blink::WebNode& node);

View file

@ -29,19 +29,19 @@ class TtsDispatcher : public blink::WebSpeechSynthesizer,
public content::RenderThreadObserver { public content::RenderThreadObserver {
public: public:
explicit TtsDispatcher(blink::WebSpeechSynthesizerClient* client); explicit TtsDispatcher(blink::WebSpeechSynthesizerClient* client);
virtual ~TtsDispatcher(); ~TtsDispatcher() override;
private: private:
// RenderProcessObserver override. // RenderProcessObserver override.
virtual bool OnControlMessageReceived(const IPC::Message& message) override; bool OnControlMessageReceived(const IPC::Message& message) override;
// blink::WebSpeechSynthesizer implementation. // blink::WebSpeechSynthesizer implementation.
virtual void UpdateVoiceList() override; void UpdateVoiceList() override;
virtual void Speak( void Speak(const blink::WebSpeechSynthesisUtterance& utterance)
const blink::WebSpeechSynthesisUtterance& utterance) override; override;
virtual void Pause() override; void Pause() override;
virtual void Resume() override; void Resume() override;
virtual void Cancel() override; void Cancel() override;
blink::WebSpeechSynthesisUtterance FindUtterance(int utterance_id); blink::WebSpeechSynthesisUtterance FindUtterance(int utterance_id);