mirrors/electron
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions 1

[chromium-style] override / virtual warnings

Browse source
This commit is contained in:
Jeremy Apthorp 2018-04-17 16:03:51 -07:00
parent a635f078c6
commit e6695cf2ec
62 changed files with 106 additions and 106 deletions
Download patch file Download diff file Expand all files Collapse all files

2
atom/browser/api/atom_api_auto_updater.h
View file

@ -34,7 +34,7 @@ class AutoUpdater : public mate::EventEmitter<AutoUpdater>,
void OnError(const std::string& error) override;
void OnError(const std::string& message,
const int code,
const std::string& domain);
const std::string& domain) override;
void OnCheckingForUpdate() override;
void OnUpdateAvailable() override;
void OnUpdateNotAvailable() override;

2
atom/browser/api/atom_api_download_item.h
View file

@ -50,7 +50,7 @@ class DownloadItem : public mate::TrackableObject<DownloadItem>,
protected:
DownloadItem(v8::Isolate* isolate, content::DownloadItem* download_item);
~DownloadItem();
~DownloadItem() override;
// Override content::DownloadItem::Observer methods
void OnDownloadUpdated(content::DownloadItem* download) override;

2
atom/browser/api/atom_api_protocol.h
View file

@ -47,7 +47,7 @@ class Protocol : public mate::TrackableObject<Protocol> {
protected:
Protocol(v8::Isolate* isolate, AtomBrowserContext* browser_context);
~Protocol();
~Protocol() override;
private:
// Possible errors.

2
atom/browser/api/atom_api_session.h
View file

@ -91,7 +91,7 @@ class Session : public mate::TrackableObject<Session>,
protected:
Session(v8::Isolate* isolate, AtomBrowserContext* browser_context);
~Session();
~Session() override;
// content::DownloadManager::Observer:
void OnDownloadCreated(content::DownloadManager* manager,

2
atom/browser/api/atom_api_web_contents.h
View file

@ -262,7 +262,7 @@ class WebContents : public mate::TrackableObject<WebContents>,
content::WebContents* web_contents,
Type type);
WebContents(v8::Isolate* isolate, const mate::Dictionary& options);
~WebContents();
~WebContents() override;
void InitWithSessionAndOptions(v8::Isolate* isolate,
content::WebContents* web_contents,

2
atom/browser/api/save_page_handler.h
View file

@ -32,7 +32,7 @@ class SavePageHandler : public content::DownloadManager::Observer,
SavePageHandler(content::WebContents* web_contents,
const SavePageCallback& callback);
~SavePageHandler();
~SavePageHandler() override;
bool Handle(const base::FilePath& full_path,
const content::SavePageType& save_type);